Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: temporarily disable vpn toggle after toggling off#43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 3 commits intomainfromethan/toggle-wait-cleanup
Feb 12, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedFeb 12, 2025•
edited
Loading

There appears to be a race between the VPN service reporting itself as disconnected, and the system extension process exiting. When the VPN is toggled off and on quickly, an error is shown:

image

This PR forces the user to wait 6 seconds before they can toggle the VPN back on.

6 seconds was chosen as on my machine it takes about that long for the app to log that the XPC connection was interrupted after thestopTunnel function returns, and the system informs the app the VPN has been disconnected.

The XPC connection in the network extension is in the global scope, so it makes sense for it's death to imply the process has finally exited.

Potentially related:
image
https://developer.apple.com/forums/thread/84920?answerId=252931022#252931022

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewFebruary 12, 2025 14:43
Copy link
Member

@ThomasK33ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure if we need this, as when toggling quickly in Tailscale, it leaves me in a disconnected state.
But I can see this being good enough for now.

@ethanndickson
Copy link
MemberAuthor

Yeah, I just thought a light guardrail can't hurt - it also means people are less likely to report it as an issue!

@ethanndicksonethanndickson merged commitb8d110a intomainFeb 12, 2025
4 checks passed
@ThomasK33ThomasK33 deleted the ethan/toggle-wait-cleanup branchFebruary 12, 2025 15:32
ethanndickson added a commit that referenced this pull requestFeb 20, 2025
Depends oncoder/coder#16598.Reverts#43.Whilst everything seems to recover okay tailnet wise when waking from sleep currently, the tunnel will still miss workspace/peer updates during the sleep, causing the workspace state in the UI to be out of sync with reality. To handle this, we'll teardown the tunnel on sleep, and bring it back up on wake.Fixing the issue in `coder/coder` also revealed that the error encountered when toggling the VPN on and off quickly was another symptom, and so this change reverts the code that prevents toggling the VPN on and off quickly, as it now works flawlessly.
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ThomasK33ThomasK33ThomasK33 approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@ThomasK33
[8]ページ先頭
©2009-2025 Movatter.jp