coder/coder-desktop-macosPublic

NotificationsYou must be signed in to change notification settings
Fork3
Star16

feat: pass agent updates to UI#35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethanndickson merged 2 commits intomainfromethan/agents-to-ui

Feb 10, 2025

Merged

feat: pass agent updates to UI#35

ethanndickson merged 2 commits intomainfromethan/agents-to-ui

Feb 10, 2025

Conversation

Copy link

Member

ethanndickson commentedJan 31, 2025•
edited
Loading

Closes#5.

Passes Agent updates over XPC to the UI, displaying them on the menubar app
GUI now receives notifications when the system VPN state changes.

Copy link

MemberAuthor

ethanndickson commentedJan 31, 2025•
edited
Loading

ci: build for distribution #37
chore: support operating the VPN without the app #36
feat: pass agent updates to UI #35 👈(View in Graphite)
main

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

ethanndickson commented

Jan 31, 2025

View reviewed changes

Coder Desktop/VPNLib/vpn.proto Outdated

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Updated fromcoder/coder

Coder Desktop/project.yml

		PRODUCT_BUNDLE_IDENTIFIER: com.coder.Coder-Desktop.CoderSDKTests

		VPNXPC:
		type: framework

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now that we import VPNLib into the app for the peer update protobuf type, we might as well just put the contents of this framework there.

Coder Desktop/Coder Desktop/Views/Util.swift

		guard uuidData.count == 16 else {
		return nil
		}
		var uuid: uuid_t = (0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very funny: there's no fixed size arrays in Swift (probably cause of objc), souuid_t is just a tuple of 16 u8s.
Also, the proposal to add one includes calling that new type a Vectorhttps://forums.swift.org/t/second-review-se-0453-vector-a-fixed-size-array/76412/20

Coder Desktop/Coder Desktop/VPNService.swift

		logger.error("network extension reported error: \(error)")
		tunnelState = .failed(.internalError(error.localizedDescription))
		extension CoderVPNService {
		@objc private func vpnDidUpdate(_ notification: Notification) {

Copy link

MemberAuthor

ethanndicksonJan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

macOS can tell us when the Network Extension changes state, including if there was an error that caused it to disconnect, e.g. NE crashes,ptp.cancelTunnelWithError, start/stopcompletionHandler(err)