Passes the session token to the network extension via the VPN configuration (seeSecurely pass a Coder session token to the (System) Network Extension #33)
Properly applies tunnel settings by layering multiple requests from the dylib (as DNS settings are sent seperately from IP addresses and routes)

With this, the VPN functionality works end-to-end! Once the system extension is enabled, and the app has been logged in, starting the VPN will make the user's workspaces available on<wsname>.coder

chore: pass session token to network extension

3e44972

Copy link

MemberAuthor

ethanndickson commentedJan 30, 2025

chore: pass session token to network extension #34 👈(View in Graphite)
main

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

ethanndickson commented

Jan 30, 2025

View reviewed changes

Coder Desktop/.swiftformat

		@@ -0,0 +1,3 @@
		--selfrequired log,info,error,debug,critical,fault

Copy link

MemberAuthor

ethanndicksonJan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

From thedocs:

In the rare case of functions with@autoclosure arguments, self may be required at the call site, but SwiftFormat is unable to detect this automatically. You can use the --selfrequired command-line option to specify a list of such methods, and the redundantSelf rule will then ignore them.

Coder Desktop/VPNLib/Receiver.swift

		throw .alreadyRunning
		}
		running = true
		return AsyncStream(

Copy link

MemberAuthor

ethanndicksonJan 30, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

messages() is called each timenext() is called on theSpeaker, but it's not possible to mutate therunning variable from within the stream in Swift 6.

Even if it were possible, I don't think this check is of any value. Isn't it usually the case (in general) that iterating over the same (mutating) stream multiple times is just an incorrect use of an API? I think actor re-entrancy means it's possible to do so here.

If we do want to keep the check, I'm open to suggestions on how best to do that.