Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add XPC communication to Network Extension#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 20 commits intomainfromcolin/xpc
Jan 30, 2025

Conversation

coadler
Copy link
Contributor

@coadlercoadler commentedJan 23, 2025•
edited
Loading

No description provided.

@coadler
Copy link
ContributorAuthor

I implemented communication updates from the NetworkExtension to the App, but it doesn't seem like the network extension is ever fully starting up. I see that it's being started, but never see any logs instartTunnel. It also always prints the following error:

failed to read proto message: Error Domain=SwiftProtobuf.BinaryDecodingError Code=1

@ethanndickson
Copy link
Member

ethanndickson commentedJan 24, 2025•
edited
Loading

The somewhat good news is that error log is from the Speaker trying to read the start response from the tunnel. You're not seeing the logs instartTunnel becauseConsole.app doesn't show Debug & Info by default.
image
image

Copy link
Member

@ethanndicksonethanndickson left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In the interest of getting this merged, the rest of my review is in the last commit!

Comment on lines 48 to 49
// TODO: better init maybe? kinda wonky
lazy var xpc = VPNXPCInterface(vpn: self)
Copy link
Member

@ethanndicksonethanndicksonJan 30, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is fine, since it's a chicken & egg problem. The alternative is to use an optional, probably with! - lazy lets us skip the unwrap.

@ethanndicksonethanndickson merged commit15f2bcc intomainJan 30, 2025
3 checks passed
@ethanndicksonethanndickson deleted the colin/xpc branchJanuary 30, 2025 10:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@coadler@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp