Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: hold delegate reference to keep it from being deallocated#26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/fix-sys-extn-delegate
Jan 21, 2025

Conversation

spikecurtis
Copy link
Collaborator

@spikecurtisspikecurtis commentedJan 21, 2025•
edited
Loading

The problem we were having before was being caused by the system extension delegate being deallocated before the request responses came back.

I didn't initially realize this, but theOSSystemRequest.delegate is a weak reference (you have to click down to the individual field view in the docs to learn this).

So, we keep a strong reference from the VPNService around while we are waiting for the extension to install.

@spikecurtisGraphite App
Copy link
CollaboratorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewJanuary 21, 2025 06:15
Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice!

@spikecurtisGraphite App
Copy link
CollaboratorAuthor

spikecurtis commentedJan 21, 2025•
edited
Loading

Merge activity

  • Jan 21, 1:48 AM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Jan 21, 1:48 AM EST:Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected.
  • Jan 21, 5:05 AM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Jan 21, 5:05 AM EST: A user merged this pull request withGraphite.

@spikecurtisspikecurtisforce-pushed thespike/fix-sys-extn-delegate branch from62199d8 to33294faCompareJanuary 21, 2025 08:18
@spikecurtisspikecurtis merged commit962c369 intomainJan 21, 2025
4 checks passed
@ethanndicksonethanndickson deleted the spike/fix-sys-extn-delegate branchJanuary 23, 2025 02:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp