chore: gracefully shutdown app#25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethanndickson merged 2 commits intomainfromethan/app-shutdown

Jan 22, 2025

Merged

chore: gracefully shutdown app#25

ethanndickson merged 2 commits intomainfromethan/app-shutdown

Jan 22, 2025

+69 −25

Conversation

Copy link

Member

ethanndickson commentedJan 17, 2025•
edited
Loading

When the app is quit (terminated), in any way, an active VPN connection should first be shutdown by sending the stop response over the tunnel. Previously we were only catching when the app was closed via the quit button we supply, but we can actually catch any non-force-quit terminations using theAppDelegate.

Additionally:

Quitting the app while the VPN is stopping should wait for the existing stop operation to finish
Quitting the app while the VPN is starting should wait for the start operation to finish, and then start and wait for a stop operation.