This PR adds a settings menu to the app, and a network tab with a form for specifying hard-coded HTTP headers to be added on all outgoing requests. The settings cannot be modified while Coder VPN is on, as they can't be applied to the DERP headers without restarting the tailnet connection.

literalheaderflow.mov

Future work includes:

Sending these headers to the Network Extension whenever they change, via XPC.
Adding support for dynamic, shell command-based headers, as also supported by the CLI.

This was referencedJan 16, 2025

chore: extract CoderSDK to framework#19

Merged

fix: set pipefail during make test#22

Merged

Copy link

MemberAuthor

ethanndickson commentedJan 16, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

ethanndickson mentioned this pull request

Jan 16, 2025

chore: improve login form styling#23

Merged

ethanndickson force-pushed theethan/nicer-login-form branch from7173c04 to5133c65Compare

January 16, 2025 07:36

ethanndickson force-pushed theethan/literal-header-settings branch 2 times, most recently from46b4141 to2638e0cCompare

January 17, 2025 09:10

ethanndickson force-pushed theethan/nicer-login-form branch fromf0465a3 to5d97953Compare

January 17, 2025 09:18

ethanndickson force-pushed theethan/literal-header-settings branch from2638e0c to4b77803Compare

January 17, 2025 09:19

ethanndickson commented

Jan 17, 2025

View reviewed changes

Makefile

		@@ -21,8 +21,7 @@ test:
		-testPlan $(SCHEME) \
		-skipPackagePluginValidation \
		CODE_SIGNING_REQUIRED=NO \
		CODE_SIGNING_ALLOWED=NO \
		\| LC_ALL="en_US.UTF-8" xcpretty

Copy link

MemberAuthor

ethanndicksonJan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was debugging a CI-only test failure andxcpretty was swallowing a helpful error log -xcbeautify seems like it provides better output in general for tests.

For context, the default xcodebuild output is thousands of lines, and not at all readable.

ethanndickson marked this pull request as ready for review

January 17, 2025 09:49

ethanndickson force-pushed theethan/literal-header-settings branch 2 times, most recently fromc8ad579 todc8972eCompare

January 17, 2025 10:13

ethanndickson commented

Jan 17, 2025

View reviewed changes

Coder Desktop/Coder Desktop.xcodeproj/project.pbxproj

		@@ -955,7 +998,7 @@
		"$(inherited)",
		"@executable_path/../Frameworks",
		);
		MACOSX_DEPLOYMENT_TARGET = 14.6;
		MACOSX_DEPLOYMENT_TARGET = 14.0;

Copy link

MemberAuthor

ethanndicksonJan 17, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We need to discuss what minimum macOS version we want to target. On one hand, an app like Tailscale supports versions as old as 11 from 2020, but on the other hand, I suspect most enterprises will be keeping their company devices on 14 or 15, though it'd be nice to know for sure.

Fortunately, we could set this value to13 right now, which is the earliest version Apple still 'supports' (they don't really have a policy FWICT, but the pattern seems to be security updates for the last three versions)

The big feature in 14SwiftData, is a Swift interface for a sqlite-backed app database. I messed around with it for this feature, but it's definitely overkill here. It might be super useful in the future?