Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: always open app as logged-in user in postinstall script#216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/run-reopened-gui-app-as-user
Aug 6, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 5, 2025•
edited
Loading

This PR prevents issues like:

Screenshot 2025-07-30 at 3 57 07 pm

which occur when the app is launched as root. This can happen when the installer scripts are run as root, which is the case when deploying Coder Desktop over MDM. (As a convenience, we re-open the app if it was open before the installer was ran.)

Of note is that on macOS, it is not sufficient to just run open withsudo -u, as that does not use the execution context of the user. Seehttps://developer.apple.com/forums/thread/78332

Reports of the bug in other programs:
(with an incorrect solution)https://community.zoom.com/t5/Zoom-Meetings/A-keychain-cannot-be-found-to-stoer-quot-Zoom-quot/m-p/51059
https://displaylink.org/forum/showthread.php?p=97176

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 5, 2025•
edited
Loading

@ethanndicksonethanndicksonforce-pushed theethan/run-reopened-gui-app-as-user branch 2 times, most recently from5e2a549 to2794fe6CompareAugust 5, 2025 06:52
@ethanndicksonethanndickson self-assigned thisAug 5, 2025
@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 5, 2025 07:28
@ethanndicksonethanndickson changed the titlefix: always run postinstall app open as logged-in userfix: always open app as logged-in user in postinstall scriptAug 5, 2025
@ethanndicksonethanndicksonforce-pushed theethan/progress-auto-start branch fromf3468db tod04e73fCompareAugust 6, 2025 02:24
@ethanndicksonethanndicksonforce-pushed theethan/run-reopened-gui-app-as-user branch from2794fe6 tof404c56CompareAugust 6, 2025 02:24
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR fixes an issue where the Coder Desktop app would launch as root when installed via MDM, causing keychain access problems. The fix ensures the app always launches under the logged-in user's context in the postinstall script.

Key changes:

  • Replaces simpleopen -a command with user-specific launch command
  • Adds logic to detect the current console user and launch the app under their context
  • Includes explanatory comments about the MDM deployment scenario

@ethanndicksonethanndicksonforce-pushed theethan/progress-auto-start branch fromd04e73f to0dc424cCompareAugust 6, 2025 03:37
@ethanndicksonethanndicksonforce-pushed theethan/run-reopened-gui-app-as-user branch fromf404c56 to0d77ec3CompareAugust 6, 2025 03:38
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 6, 2025•
edited
Loading

Merge activity

  • Aug 6, 3:39 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Aug 6, 3:57 AM UTC:Graphite rebased this pull request as part of a merge.
  • Aug 6, 3:59 AM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/progress-auto-start tographite-base/216August 6, 2025 03:54
@ethanndicksonethanndickson changed the base branch fromgraphite-base/216 tomainAugust 6, 2025 03:56
@ethanndicksonethanndicksonforce-pushed theethan/run-reopened-gui-app-as-user branch from0d77ec3 toe51c8a7CompareAugust 6, 2025 03:57
@ethanndicksonethanndickson merged commit4ba6ca3 intomainAug 6, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/run-reopened-gui-app-as-user branchAugust 6, 2025 03:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp