- Notifications
You must be signed in to change notification settings - Fork5
chore: set minimum coder server version to v2.24.3#215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedAug 4, 2025
MemberAuthor
ethanndickson commentedAug 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
deansheather approved these changesAug 4, 2025
60f8964 toacf0aebCompare29b1d77 to8f34725Compareacf0aeb tof3468dbCompare8f34725 to732f055Compare732f055 to18604cdCompare2794fe6 tof404c56Comparea28b21c to3a4e672CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the minimum required Coder server version from v2.24.2 to v2.25.0 to support VPN daemon functionality on macOS CLI. The change is necessary because thevpn-daemon command is only available in Coder server v2.25.0 and later versions.
- Updates minimum Coder version requirement from v2.24.2 to v2.25.0
- Adds VPNLib framework dependency to the project configuration
- Updates test to dynamically reference the minimum version constant
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Coder-Desktop/project.yml | Adds VPNLib framework as a non-embedded dependency |
| Coder-Desktop/VPNLib/Validate.swift | Updates minimum Coder version constant from "2.24.2" to "2.25.0" |
| Coder-Desktop/Coder-DesktopTests/LoginFormTests.swift | Updates test to use dynamic version reference instead of hardcoded value |
Uh oh!
There was an error while loading.Please reload this page.
3a4e672 to8edcc5aComparef404c56 to0d77ec3Compare0d77ec3 to4ba6ca3Compare8edcc5a to6d8c03aCompare6d8c03a toc7bd12aComparec7bd12a to4352ef6CompareMemberAuthor
ethanndickson commentedAug 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
f5d0741 intomain 4 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This requirement is introduced by#210, as the
vpn-daemoncommand on the macOS CLI isn't present on prior versions.(2.24.3 isn't out yet, but when it does come out, it'll be compatible. 2.25 is out, and it's compatible)