Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: start coder connect progress indicator immediately#214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/progress-auto-start
Aug 6, 2025

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 4, 2025•
edited
Loading

With the changes made in#203, it now takes a moment longer to receive the first progress update, when we either start the download (if not already downloaded), or validate the dylib. To address this, the progress indicator will immediately start making progress towards 25%. This prevents it from appearing stuck in what is an expected situation.

autoStartDemo.mov

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 4, 2025•
edited
Loading

@ethanndicksonethanndicksonforce-pushed theethan/validate-slim-binary-version branch fromab9ca27 to50e4a63CompareAugust 4, 2025 09:42
@ethanndicksonethanndicksonforce-pushed theethan/progress-auto-start branch fromdf10a17 to60f8964CompareAugust 4, 2025 09:42
@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 4, 2025 09:46
@ethanndicksonethanndickson self-assigned thisAug 4, 2025
@ethanndicksonethanndicksonforce-pushed theethan/progress-auto-start branch from60f8964 toacf0aebCompareAugust 4, 2025 12:53
@ethanndicksonethanndicksonforce-pushed theethan/validate-slim-binary-version branch from50e4a63 to8fb9382CompareAugust 4, 2025 12:53
@ethanndicksonethanndicksonforce-pushed theethan/progress-auto-start branch fromacf0aeb tof3468dbCompareAugust 5, 2025 04:51
@ethanndicksonethanndicksonforce-pushed theethan/validate-slim-binary-version branch from8fb9382 to431149fCompareAugust 5, 2025 04:51
@ethanndicksonethanndicksonforce-pushed theethan/progress-auto-start branch fromf3468db tod04e73fCompareAugust 6, 2025 02:24
@ethanndicksonethanndicksonforce-pushed theethan/validate-slim-binary-version branch from431149f to8fceeabCompareAugust 6, 2025 02:24
Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR fixes a UX issue where the coder connect progress indicator appears stuck at the beginning of the process by implementing an immediate auto-start animation that progresses to 25% over 2 seconds.

  • Adds anautoStart feature toCircularProgressView that begins animating immediately when the initial value is 0
  • Updates the VPN progress mapping to accommodate the new auto-start behavior and adjusts thresholds accordingly
  • Modifies the auto-complete threshold from 50% to 65% to account for the updated progress ranges

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
CircularProgressView.swiftAdds auto-start functionality with state management and animation logic
VPNProgress.swiftUpdates progress mapping values and configures auto-start behavior

@ethanndicksonethanndicksonforce-pushed theethan/validate-slim-binary-version branch from8fceeab to62c3d0aCompareAugust 6, 2025 03:37
@ethanndicksonethanndicksonforce-pushed theethan/progress-auto-start branch fromd04e73f to0dc424cCompareAugust 6, 2025 03:38
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 6, 2025•
edited
Loading

Merge activity

  • Aug 6, 3:39 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Aug 6, 3:54 AM UTC:Graphite rebased this pull request as part of a merge.
  • Aug 6, 3:56 AM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/validate-slim-binary-version tographite-base/214August 6, 2025 03:51
@ethanndicksonethanndickson changed the base branch fromgraphite-base/214 tomainAugust 6, 2025 03:53
@ethanndicksonethanndicksonforce-pushed theethan/progress-auto-start branch from0dc424c to41ff4aaCompareAugust 6, 2025 03:54
@ethanndicksonethanndickson merged commit8d9f844 intomainAug 6, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/progress-auto-start branchAugust 6, 2025 03:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp