Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: prompt for sign in when toggling coder connect on#204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/sign-in-on-vpn-toggle-regression
Jul 24, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJul 23, 2025
edited
Loading

I undid the work of#114 in#158, by disabling the VPN toggle when the network extension was unconfigured.
When signed out, the network extension is unconfigured.
This PR adds a special exception to make the VPN toggle always clickable when signed out, as it has special behaviour when signed out.
It also adds a proper regression test. A slightly different regression test existed, but it didn't account for cases where the VPN state is one that would normally disable the toggle.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewJuly 23, 2025 15:09
@ethanndicksonethanndicksonforce-pushed theethan/sign-in-on-vpn-toggle-regression branch 2 times, most recently fromcfefe70 to2012727CompareJuly 23, 2025 15:23
@ethanndicksonethanndicksonforce-pushed theethan/sign-in-on-vpn-toggle-regression branch from2012727 to0b34361CompareJuly 23, 2025 15:25
@ethanndicksonethanndickson self-assigned thisJul 23, 2025
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedJul 24, 2025
edited
Loading

Merge activity

  • Jul 24, 3:15 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Jul 24, 3:15 AM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson merged commitfaaa0af intomainJul 24, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/sign-in-on-vpn-toggle-regression branchJuly 24, 2025 03:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ibetitsmikeibetitsmikeibetitsmike approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@ibetitsmike

[8]ページ先頭

©2009-2025 Movatter.jp