Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: install and activate the tunnel provider as network extension#20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 3 commits intomainfromspike/network-extension-install
Jan 14, 2025

Conversation

spikecurtis
Copy link
Collaborator

@spikecurtisspikecurtis commentedJan 10, 2025•
edited
Loading

With apologies, I'm sort of punting on this one for the time being.

The code works to install and allow activation of the Network Extension, but for some reason the delegate I've created to get updates about the System Extension installation is not getting called back.

I've posted on the Apple Developer Forums about it:https://forums.developer.apple.com/forums/thread/772236

In the meantime, I'm hoping to get some feedback about the code and overall design. I'll leave it in draft for now.

@spikecurtisGraphite App
Copy link
CollaboratorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtisforce-pushed thespike/network-extension-install branch 2 times, most recently from3b95b81 to1683ca6CompareJanuary 10, 2025 11:20
Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm so far!

@ethanndickson
Copy link
Member

Rebasing...

@ethanndicksonethanndicksonforce-pushed thespike/network-extension-install branch from1683ca6 to9e0b05bCompareJanuary 14, 2025 05:30
@ethanndickson
Copy link
Member

Merging so Colin can just work off main

@ethanndicksonethanndickson marked this pull request as ready for reviewJanuary 14, 2025 05:43
@ethanndicksonethanndickson merged commit90d124c intomainJan 14, 2025
4 checks passed
@ethanndicksonethanndickson deleted the spike/network-extension-install branchJanuary 23, 2025 02:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp