Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: minor ui/ux changes#186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromethan/minor-ux
Jun 18, 2025
Merged

chore: minor ui/ux changes#186

ethanndickson merged 2 commits intomainfromethan/minor-ux
Jun 18, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJun 18, 2025•
edited
Loading

These changes were in response to feedback:

  • Adds tooltips on hover to the copy DNS button, and the open in browser button on the main tray menu.
  • Includes the download URL in the error message if the client receives an unexpected HTTP code when downloading.
  • Makes the file sync table controls a lil bigger (24px -> 28px):
    • Before:
    • After:

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewJune 18, 2025 01:57
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enhances UI/UX tooltips, improves error diagnostics for downloads, and standardizes sizing for file sync table controls.

  • Adds hover tooltips on the copy DNS and open-in-browser tray menu buttons.
  • Includes the download URL inDownloadError.unexpectedStatusCode messages.
  • Increases footer icon size from 24px to 30px via a newFooterIcon component andTheme.Size.tableFooterIconSize.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
VPNLib/Download.swiftUpdatedDownloadError.unexpectedStatusCode to include URL and adjusted error resume call.
Views/VPN/VPNMenuItem.swiftAdded.help(...) modifiers to show tooltips on hover for copy and open buttons.
Views/FileSync/FileSyncConfig.swiftReplaced fixed 24px frames withFooterIcon, increased size to 30px, and updated padding.
Theme.swiftAddedTheme.Size.tableFooterIconSize to centralize the new footer icon dimension.
Comments suppressed due to low confidence (4)

Coder-Desktop/VPNLib/Download.swift:149

  • Consider adding a unit test that triggers an unexpected status code and asserts that the error description includes both the HTTP code and the download URL.
    case unexpectedStatusCode(Int, url: String)

Coder-Desktop/VPNLib/Download.swift:149

  • [nitpick] It may be safer to store the URL as aURL type instead ofString in the error, preserving type information and avoiding downstream parsing issues.
    case unexpectedStatusCode(Int, url: String)

Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift:149

  • The play/pause toggle logic appears inverted: whenisResumable is true (i.e., the session is paused), you should show a play icon with tooltip "Resume", and vice versa for pausing.
                                FooterIcon(systemName: "play")

Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift:206

  • [nitpick] IfFooterIcon is intended for reuse across multiple views, consider moving it into a shared UI components file or adding a doc comment to clarify its purpose.
struct FooterIcon: View {

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedJun 18, 2025•
edited
Loading

Merge activity

  • Jun 18, 8:09 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Jun 18, 8:09 AM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit99d4e4d intomainJun 18, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/minor-ux branchJune 18, 2025 08:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@deansheatherdeansheatherdeansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp