Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: improve performance of indeterminate spinner#184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/spinner-performance
Jun 16, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJun 16, 2025•
edited
Loading

A user reported a constant 10% CPU usage whilst the Cursor svg failed to load. It turns out unnecessarily tying a looping animation to some state in SwiftUI is a bad idea. If you want to render a looping animation that's not tied to some state, you should use the CoreAnimation framework. In this case, we use aCABasicAnimation.

We leave the determinate spinner unmodified, as it by definition must be tied to some SwiftUI state.

Before:
before
After:
after

matifali reacted with hooray emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewJune 16, 2025 03:53
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedJun 16, 2025•
edited
Loading

Merge activity

  • Jun 16, 2:17 PM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Jun 16, 2:17 PM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit9a7b776 intomainJun 16, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/spinner-performance branchJune 16, 2025 14:17
@ethanndicksonethanndickson self-assigned thisJun 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp