Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add dylib downloader and validator#16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 17 commits intomainfromethan/dylib-download
Jan 14, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJan 7, 2025
edited
Loading

First PR for#2.

This PR adds an abstraction for downloading & validating the dylib from a Coder server, and the network extension scaffolding.

It also adds aTunnelHandle type for owning the pair of pipes passed to the dylib, and the handle to the dylib itself.

You cannot create a unit test target that targets a System Extension. So, this PR extracts the portion of the network extension that we'd like to test into it's own Framework,VPNLib.

Of note is thatSwiftProtobuf doesn't have a stable ABI (as it doesn't uselibrary evolution), so the Framework has theBuild libraries for distribution setting disabled. This shouldn't effect anything. Exporting theSwiftProtobuf types should be fine provided we don't importSwiftProtobuf in to theVPN target as well.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedJan 7, 2025
edited
Loading

@ethanndicksonethanndickson marked this pull request as ready for reviewJanuary 7, 2025 11:00
@ethanndicksonethanndickson self-assigned thisJan 7, 2025
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedJan 14, 2025
edited
Loading

Merge activity

  • Jan 13, 11:47 PM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Jan 13, 11:48 PM EST: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit161e5c2 intomainJan 14, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/dylib-download branchJanuary 14, 2025 05:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@spikecurtis

[8]ページ先頭

©2009-2025 Movatter.jp