Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: send push notifications for invalidcoder scheme URIs#146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromethan/push-notif
May 12, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMay 5, 2025•
edited
Loading

Relates to#96.

imageimage

I've had to replace theapp provisioning profile for this to build.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMay 5, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

matifali reacted with heart emoji

@ethanndicksonethanndicksonforce-pushed theethan/push-notif branch 2 times, most recently fromf6bc9e3 to83b1554CompareMay 6, 2025 02:55
@ethanndicksonethanndickson marked this pull request as ready for reviewMay 6, 2025 03:57
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds push notification support for invalid coder scheme URIs, which involves updating the app provisioning profile and integrating notification logic into the application.

  • Updated project plist with the appropriate APS environment key.
  • Added a new notification delegate and helper function for sending notifications.
  • Integrated asynchronous error handling with push notifications in the app delegate.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

FileDescription
Coder-Desktop/project.ymlInserts the APS environment configuration for push notifications.
Coder-Desktop/Coder-Desktop/Notifications.swiftAdds a new notification delegate and helper to send notifications.
Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swiftConfigures the notification delegate and handles errors by sending a push notification.
Comments suppressed due to low confidence (1)

Coder-Desktop/project.yml:150

  • Ensure that the 'aps-environment' key is properly indented and aligned with similar keys under the entitlements section to avoid potential configuration issues.
aps-environment: development

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMay 12, 2025•
edited
Loading

Merge activity

  • May 11, 10:46 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • May 11, 10:47 PM EDT:Graphite rebased this pull request as part of a merge.
  • May 11, 10:48 PM EDT:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/uri-handler tographite-base/146May 12, 2025 02:46
@ethanndicksonethanndickson changed the base branch fromgraphite-base/146 tomainMay 12, 2025 02:46
@ethanndicksonethanndickson merged commit2198d3e intomainMay 12, 2025
1 check passed
@ethanndicksonethanndickson deleted the ethan/push-notif branchMay 12, 2025 02:48
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@deansheatherdeansheatherdeansheather approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp