Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add handler and router forcoder scheme URIs#145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 5 commits intomainfromethan/uri-handler
May 12, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMay 5, 2025•
edited
Loading

Relates to#96.
Closes#95

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMay 5, 2025•
edited
Loading

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is attached to thecoder scheme.

@ethanndickson
Copy link
MemberAuthor

ethanndickson commentedMay 5, 2025•
edited
Loading

I've run into the same issue described in#98, but withswift-collections when testing a release build of this PR stack. A development build works fine, but once the app is bundled with the dependency added in this PR,InternalCollectionsUtilities.framework is embedded into the app bundle but not the system extension bundle. This causes the system extension to panic on launch as it can't find the framework.

Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds a handler and router to processcoder scheme URIs while updating the project dependency configuration and deep link handling. Key changes include:

  • Adding the URLRouting package to the project configuration.
  • Implementing a new router in VPNLib to parse and match coder URLs.
  • Incorporating tests for various routing scenarios and updating deep link handling in the app delegate.

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
Coder-Desktop/project.ymlAdded URLRouting package dependency and updated targets.
Coder-Desktop/VPNLibTests/CoderRouterTests.swiftIntroduced comprehensive tests for the new router implementation.
Coder-Desktop/VPNLib/CoderRouter.swiftImplemented the router and its associated types for coder URIs.
Coder-Desktop/Coder-Desktop/URLHandler.swiftAdded a URL handler to process matching coder URLs with error handling.
Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swiftUpdated deep link handling by integrating the new URL handler.
Files not reviewed (3)
  • Coder-Desktop/Coder-Desktop/Info.plist: Language not supported
  • Makefile: Language not supported
  • scripts/build.sh: Language not supported

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMay 12, 2025•
edited
Loading

Merge activity

  • May 11, 10:46 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • May 11, 10:46 PM EDT:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit0cf2f28 intomainMay 12, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/uri-handler branchMay 12, 2025 02:46
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@deansheatherdeansheatherdeansheather approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coder URL scheme
2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp