• chore: upgrade Proto code to Swift 6 #14 👈(View in Graphite)
• main

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

Just thinking about it after the fact, is there a reason we wouldn't want to make Speaker & Handshaker an actor?

Just thinking about it after the fact, is there a reason we wouldn't want to make Speaker & Handshaker an actor?

The reason I didn't makeSpeaker and actor is that as far as I can tell, actors don't have inheritance. An alternative design might be to make theSpeaker an actor, and then have theTunnel and/orManager compose aSpeaker internally. However, we'd have to rethink the way the outer object gets notified about messages and RPCs --- overriding handlers won't work.

For theHandshaker, I was having trouble getting it to work because of the way we use DispatchIO callbacks to write to the data: data has to be mutable and DispatchIO callbacks aren'tasync. I couldn't figure out how to make an actor work for that.

Merge activity

• Dec 19, 4:46 AM EST: A user started a stack merge that includes this pull request viaGraphite.
• Dec 19, 4:46 AM EST: A user merged this pull request withGraphite.