Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add progress messages when creating sync sessions#139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 5 commits intomainfromethan/sync-progress
May 1, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedApr 23, 2025•
edited
Loading

This loading might take a minute on a poor connection, and there's currently no feedback indicating what's going on, so we can display the prompt messages in the meantime.

i.e. setting up a workspace with a fair bit of latency:

createsyncprogress.mov

This PR also contains a small refactor for theAgentprimaryHost, removing all the subsequent nil checks as we know it exists on creation.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedApr 23, 2025•
edited
Loading

@ethanndicksonethanndickson marked this pull request as ready for reviewApril 23, 2025 03:57
@@ -69,6 +68,9 @@ struct VPNMenuState {
invalidAgents.append(agent)
return
}
// Remove trailing dot if present
let nonEmptyHosts = agent.fqdn.map { $0.hasSuffix(".") ? String($0.dropLast()) : $0 }
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The array being non-empty is checked above.

@ethanndickson
Copy link
MemberAuthor

I redid it using a callback instead of some global state, and added a progressview:
image

matifali reacted with heart emoji

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMay 1, 2025•
edited
Loading

Merge activity

  • Apr 30, 10:18 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Apr 30, 10:20 PM EDT:Graphite rebased this pull request as part of a merge.
  • Apr 30, 10:20 PM EDT:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/workspace-apps tographite-base/139May 1, 2025 02:18
@ethanndicksonethanndickson changed the base branch fromgraphite-base/139 tomainMay 1, 2025 02:19
@ethanndicksonethanndickson merged commit6210775 intomainMay 1, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/sync-progress branchMay 1, 2025 02:20
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp