Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: support old VPN config names in post & pre install scripts#134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromethan/handle-vpn-config-name-change
Apr 15, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedApr 14, 2025
edited
Loading

One thing I noticed as part of my work on#121 is that our attempted fix introduced in#92 wasn't working as expected if the user had a VPN configuration installed before#86.

This PR fetches the unique name of the VPN service dynamically, as part of the script, such that the service is started and stopped regardless of whether the service is called "Coder" or the older "CoderVPN".

This also ensures we don't break it again if we ever change that name, such as to "Coder Connect" (I don't totally recall why it was set to "Coder", but I don't mind it)

matifali reacted with thumbs up emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndicksonforce-pushed theethan/handle-vpn-config-name-change branch from8750617 to47d3dcaCompareApril 15, 2025 01:22
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedApr 15, 2025
edited
Loading

Merge activity

  • Apr 14, 9:29 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Apr 14, 9:29 PM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit33da515 intomainApr 15, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/handle-vpn-config-name-change branchApril 15, 2025 01:36
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp