Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: use the deployment's hostname suffix in the UI#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 10 commits intomainfromethan/deployment-hostname-suffix
Apr 15, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedApr 10, 2025•
edited
Loading

Closes#93.

image

The only time the hostname suffix is used by the desktop app is when an offline workspace needs to be shown in the list, where we naively append.coder. This PR sets this appended value to whatever--workspace-hostname-suffix is configured to deployment-side.

We read the config value from the deployment when:

  • The app is launched, if the user is signed in.
  • The user signs in.
  • The VPN is started.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewApril 10, 2025 06:46
headers: useLiteralHeaders ? literalHeaders.map { $0.toSDKHeader() } : []
)
Task {
await handleTokenExpiry()
Copy link
MemberAuthor

@ethanndicksonethanndicksonApr 11, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

drive-by fix: we need to check for token expiry on app launch. We were previously only checking when the menu bar window was opened, and Connect was disabled. We need to account for when Connect is configured to start when the app is launched.

Comment on lines 164 to 167
// If fetching the config fails, there's likely a bigger issue.
// We'll show an error in the UI if they try and do something
logger.error("failed to refresh deployment config: \(error)")
return
Copy link
MemberAuthor

@ethanndicksonethanndicksonApr 11, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If we wanted to show that something went wrong to the user here, the UX would be awkward. I don't think we should create an alert or anything, and I don't think we should reuse the Connect failure error box.

I'm not sure how the user would get into a state where everything else was functional, except the deployment config couldn't be fetched, so I'm happy with this.

@ethanndicksonethanndickson self-assigned thisApr 11, 2025
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedApr 15, 2025•
edited
Loading

Merge activity

  • Apr 14, 9:14 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Apr 14, 9:14 PM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commitafd9634 intomainApr 15, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/deployment-hostname-suffix branchApril 15, 2025 01:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorporate dynamic workspace suffix into UI
2 participants
@ethanndickson@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp