Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add file sync daemon tests#129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 8 commits intomainfromethan/file-sync-daemon-tests
Apr 9, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedApr 4, 2025•
edited
Loading

These are just regression tests for the core file sync daemon functionality.

Also has sync sessions ignore VCS directories by default, as per the file sync RFC.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedApr 4, 2025•
edited
Loading

@ethanndicksonethanndickson marked this pull request as ready for reviewApril 7, 2025 02:17
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • Makefile: Language not supported
Comments suppressed due to low confidence (2)

Coder-Desktop/VPNLib/FileSync/FileSyncManagement.swift:22

  • The syntax 'do throws(DaemonError)' is not valid in Swift. Replace it with a standard 'do {' block for error handling.
do throws(DaemonError) {

Coder-Desktop/VPNLib/FileSync/FileSyncManagement.swift:20

  • [nitpick] Consider renaming the parameter 'arg' to a more descriptive name such as 'request' for improved clarity.
func createSession(arg: CreateSyncSessionRequest) async throws(DaemonError) {

@ethanndicksonethanndicksonforce-pushed theethan/file-sync-daemon-tests branch from2b10e0e toe48c66aCompareApril 8, 2025 03:25
@ethanndicksonethanndicksonforce-pushed theethan/file-sync-daemon-tests branch 2 times, most recently froma74e32f to0cae729CompareApril 9, 2025 03:20
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedApr 9, 2025•
edited
Loading

Merge activity

  • Apr 9, 6:01 AM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Apr 9, 6:02 AM EDT:Graphite rebased this pull request as part of a merge.
  • Apr 9, 6:04 AM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/remote-file-picker tographite-base/129April 9, 2025 10:01
@ethanndicksonethanndickson changed the base branch fromgraphite-base/129 tomainApril 9, 2025 10:01
@ethanndicksonethanndicksonforce-pushed theethan/file-sync-daemon-tests branch from0cae729 toe2a0f1bCompareApril 9, 2025 10:02
@ethanndicksonethanndickson merged commit8067574 intomainApr 9, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/file-sync-daemon-tests branchApril 9, 2025 10:04
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp