Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add remote folder picker to file sync GUI#127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 6 commits intomainfromethan/remote-file-picker
Apr 9, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedApr 3, 2025•
edited
Loading

Closes#65.

pickerexample_small.mp4
pickerstresstest.mov
image

matifali reacted with heart emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedApr 3, 2025•
edited
Loading

@ethanndicksonethanndickson marked this pull request as ready for reviewApril 3, 2025 07:42
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds a remote folder picker to the file sync GUI by integrating new API endpoints and views to enable users to select remote directories.

  • Adds Sendable conformance to the Client model and implements methods for listing agent directories in AgentLS.swift.
  • Introduces a FilePicker view, its associated model, and test cases to validate file picking logic.
  • Updates the FileSync session modal to include a remote folder picker button alongside an enhanced UI.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
Coder-Desktop/CoderSDK/Client.swiftAdded Sendable conformance to improve thread-safety.
Coder-Desktop/CoderSDK/AgentLS.swiftIntroduced LS request/response models and a new directory listing function.
Coder-Desktop/Coder-DesktopTests/Util.swiftAdded the eventually helper function for async testing.
Coder-Desktop/Coder-DesktopTests/FilePickerTests.swiftAdded tests for error handling, file loading, and directory expansion in the file picker.
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncSessionModal.swiftUpdated the file sync session modal UI to include remote folder picking capability.
Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swiftImplemented the FilePicker view, its model, and helper extensions to support file selection.
Files not reviewed (1)
  • Coder-Desktop/Coder-Desktop/Info.plist: Language not supported
Comments suppressed due to low confidence (3)

Coder-Desktop/CoderSDK/AgentLS.swift:31

  • [nitpick] Consider renaming 'absolute_path' to 'absolutePath' to follow Swift naming conventions; if these property names are tied to API keys, consider using CodingKeys for mapping.
public let absolute_path: [String]

Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncSessionModal.swift:16

  • [nitpick] Consider renaming 'pickingRemote' to 'isPickingRemote' to improve clarity and better align with SwiftUI naming conventions.
@State private var pickingRemote: Bool = false

Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift:203

  • [nitpick] Consider renaming the parameter 'dir' to 'isDirectory' to enhance readability and clarity.
dir: Bool = false

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedApr 9, 2025•
edited
Loading

Merge activity

  • Apr 9, 6:01 AM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Apr 9, 6:01 AM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commitde604d7 intomainApr 9, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/remote-file-picker branchApril 9, 2025 10:01
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@spikecurtisspikecurtisspikecurtis approved these changes

@ThomasK33ThomasK33Awaiting requested review from ThomasK33

@deansheatherdeansheatherAwaiting requested review from deansheather

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add remote folder picker to file sync GUI
3 participants
@ethanndickson@spikecurtis@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp