Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add enrichment of StartRequest with OS, device ID, version#123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 4 commits intomainfromspike/telemetry-enrichment
Mar 27, 2025

Conversation

spikecurtis
Copy link
Collaborator

@spikecurtisspikecurtis commentedMar 26, 2025•
edited
Loading

EnrichesStartRequest protocol message with device ID, OS, and version, for Coder Desktop telemetry.

@spikecurtisGraphite App
Copy link
CollaboratorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewMarch 26, 2025 12:46
Copy link
Member

@ethanndicksonethanndickson left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 after amake fmt

As an aside, I don't think we use pre-commit hooks anywhere at Coder, but it might be worth setting one up for fmt & lint?

EDIT: Also, we need to bump the version in the handshaker I believe?

@ethanndickson
Copy link
Member

ethanndickson commentedMar 26, 2025•
edited
Loading

Don't we need to bump the proto version in the Handshaker?

@spikecurtisspikecurtisforce-pushed thespike/telemetry-enrichment branch from8b9a2a3 to9da59a0CompareMarch 27, 2025 06:34
@spikecurtisGraphite App
Copy link
CollaboratorAuthor

spikecurtis commentedMar 27, 2025•
edited
Loading

Merge activity

  • Mar 27, 2:54 AM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Mar 27, 2:54 AM EDT: A user merged this pull request withGraphite.

@spikecurtisspikecurtis merged commitd311dda intomainMar 27, 2025
4 checks passed
@spikecurtisspikecurtis deleted the spike/telemetry-enrichment branchMarch 27, 2025 06:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp