Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add API errors to SDK#12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromethan/api-errs
Dec 16, 2024
Merged

chore: add API errors to SDK#12

ethanndickson merged 2 commits intomainfromethan/api-errs
Dec 16, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedDec 13, 2024•
edited
Loading

Cleanup PR to:

  • Handle error responses from SDK, improve the error handling
  • Replace the login flow errors with a popup, so we can actually display the full error
  • Update ViewInspector and fix a deprecation warning in the tests
image

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewDecember 13, 2024 02:38
Copy link
Collaborator

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some suggestions inline, but I don't need to review again.

@ethanndicksonethanndickson merged commitb338777 intomainDec 16, 2024
1 check passed
@ethanndicksonethanndickson deleted the ethan/api-errs branchJanuary 23, 2025 02:48
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp