Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: create & delete sync sessions over gRPC#119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 6 commits intomainfromethan/create-delete-grpc
Mar 28, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMar 24, 2025•
edited
Loading

Closes#63.

@ethanndicksonethanndickson self-assigned thisMar 24, 2025
@ethanndicksonethanndicksonforce-pushed theethan/create-delete-grpc branch 2 times, most recently fromc215f63 toa27014aCompareMarch 24, 2025 13:19
@ethanndicksonethanndickson marked this pull request as ready for reviewMarch 24, 2025 13:19
@@ -162,7 +168,7 @@ public class MutagenDaemon: FileSyncDaemon {
// Already connected
return
}
group = MultiThreadedEventLoopGroup(numberOfThreads:1)
group = MultiThreadedEventLoopGroup(numberOfThreads:2)
Copy link
MemberAuthor

@ethanndicksonethanndicksonMar 24, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We always have two outgoing gRPC requests at once, the prompter, and the actual request we're trying to make. This creates a second OS thread for gRPC to use.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

tbh 2 os threads might be overkill

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 28, 2025•
edited
Loading

Merge activity

  • Mar 27, 10:47 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Mar 27, 10:54 PM EDT:Graphite rebased this pull request as part of a merge.
  • Mar 27, 10:56 PM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/mutagen-prompting tographite-base/119March 28, 2025 02:51
@ethanndicksonethanndickson changed the base branch fromgraphite-base/119 tomainMarch 28, 2025 02:53
@ethanndicksonethanndickson merged commit6463de0 intomainMar 28, 2025
3 of 4 checks passed
@ethanndicksonethanndickson deleted the ethan/create-delete-grpc branchMarch 28, 2025 02:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@ThomasK33ThomasK33Awaiting requested review from ThomasK33

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add basic file sync support using GUI with manually entered paths
2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp