Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add mutagen prompting gRPC#118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/mutagen-prompting
Mar 28, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMar 21, 2025•
edited
Loading

Relates to#63.

The daemon requires this prompting communication channel be open during all requests.

@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch fromf0a7bbd tofa5aeb2CompareMarch 24, 2025 07:06
@ethanndicksonethanndickson self-assigned thisMar 24, 2025
@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch fromfa5aeb2 to7485c0fCompareMarch 24, 2025 07:09
@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch from7485c0f to2fa9ac2CompareMarch 24, 2025 09:47
@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch from2fa9ac2 toa1e03d6CompareMarch 24, 2025 09:50
@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch froma1e03d6 to8a14aa3CompareMarch 24, 2025 09:51
@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch from8a14aa3 to397007dCompareMarch 24, 2025 10:51
@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch from397007d to4fd43fdCompareMarch 24, 2025 12:32
@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch from4fd43fd to916bec7CompareMarch 24, 2025 13:12
@@ -42,9 +42,9 @@ public class MutagenDaemon: FileSyncDaemon {
privateletmutagenDaemonSocket:URL

// Non-nil when the daemon is running
varclient:DaemonClient?
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Making thisinternal instead ofprivate so we can split the daemon class up into multiple extensions, across multiple files.

// TODO: we'll always accept prompts for now
try initResp.ensureValid(first: true, allowPrompts: allowPrompts)

Task.detached(priority: .background) {
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This block is self-contained, and we're currently doing a lot on the main actor already. I was previously running into issues on startup with the VPN code getting starved by file sync code.

@ethanndicksonethanndickson marked this pull request as ready for reviewMarch 24, 2025 13:19
@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch from916bec7 to1950779CompareMarch 25, 2025 01:52
@ethanndicksonethanndicksonforce-pushed theethan/convert-mutagen-session branch from1950779 to72ac481CompareMarch 25, 2025 02:10
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 28, 2025•
edited
Loading

Merge activity

  • Mar 27, 10:47 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Mar 27, 10:51 PM EDT:Graphite rebased this pull request as part of a merge.
  • Mar 27, 10:53 PM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/convert-mutagen-session tographite-base/118March 28, 2025 02:48
@ethanndicksonethanndickson changed the base branch fromgraphite-base/118 tomainMarch 28, 2025 02:50
@ethanndicksonethanndickson merged commit2669a1c intomainMar 28, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/mutagen-prompting branchMarch 28, 2025 02:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@ThomasK33ThomasK33Awaiting requested review from ThomasK33

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp