- Notifications
You must be signed in to change notification settings - Fork5
chore: add mutagen prompting gRPC#118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMar 21, 2025
MemberAuthor
ethanndickson commentedMar 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
f0a7bbd tofa5aeb2Compare5ca8a83 toc11bc07Comparefa5aeb2 to7485c0fComparec11bc07 to1cac28dCompare7485c0f to2fa9ac2Compare1cac28d to015cd0cCompare2fa9ac2 toa1e03d6Compare015cd0c to6a40c66Comparea1e03d6 to8a14aa3Compare6a40c66 to257499fCompare8a14aa3 to397007dCompare257499f to12fa59fCompare397007d to4fd43fdCompare12fa59f toaf6ba71Compare4fd43fd to916bec7Compareaf6ba71 toae06ba2Compare| privateletmutagenDaemonSocket:URL | ||
| // Non-nil when the daemon is running | ||
| varclient:DaemonClient? |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Making thisinternal instead ofprivate so we can split the daemon class up into multiple extensions, across multiple files.
| // TODO: we'll always accept prompts for now | ||
| try initResp.ensureValid(first:true, allowPrompts: allowPrompts) | ||
| Task.detached(priority:.background){ |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This block is self-contained, and we're currently doing a lot on the main actor already. I was previously running into issues on startup with the VPN code getting starved by file sync code.
916bec7 to1950779Compareae06ba2 to68dae7dCompare1950779 to72ac481Compare68dae7d toc7018ecComparedeansheather approved these changesMar 25, 2025
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
72ac481 tofb42817Comparec7018ec to820baceCompare This was referencedMar 26, 2025
fb42817 tof25e09fCompare820bace to93667f7CompareMemberAuthor
ethanndickson commentedMar 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
93667f7 to77771a7Compare2669a1c intomain 4 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Relates to#63.
The daemon requires this prompting communication channel be open during all requests.