Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add stubbed file sync UI#116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 3 commits intomainfromethan/stubbed-fs-ui
Mar 28, 2025
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMar 20, 2025•
edited
Loading

Closes#66
Relates to#63

The UI differs a fair bit from the wireframes & figma designs in the interest of being able to use the stock SwiftUI Table view. The biggest difference is that a modal is used to insert new file syncs, as opposed to creating them inline. This was done as it's a lot harder to do that within a SwiftUI table. This design is also consistent with tables used in Apple's own settings pages, and the HTTP header table in app settings.

Screen.Recording.2025-03-20.at.1.55.34.pm.mov

The UI is mostly non-functional, it still needs to be wired up over gRPC, including conversions from Mutagen data types.
As a result, the file sync button on the menu will not appear unless the file sync feature flag is enabled in settings.

Right now, the workspace dropdown menu is populated from the online agents (any row with a coloured dot on the menubar menu)

There's no tests for this since ViewInspector still does not support Tables.

matifali reacted with heart emoji
@ethanndicksonethanndickson marked this pull request as ready for reviewMarch 20, 2025 02:59
@deansheather
Copy link
Member

How come is there a dot on the menu to open the file sync list?

@ethanndickson
Copy link
MemberAuthor

image
It's wired up to the daemon status. no active sessions == mutagen daemon isn't running == gray dot.

@deansheather
Copy link
Member

Oh... it's kinda weird to have a green dot as if it's a workspace. I'll ping Rachel about the design I guess

@ethanndicksonethanndickson linked an issueMar 20, 2025 that may beclosed by this pull request
@ethanndicksonethanndickson self-assigned thisMar 24, 2025
@ethanndicksonethanndicksonforce-pushed theethan/stubbed-fs-ui branch 2 times, most recently from5fca50f tofceb8a5CompareMarch 24, 2025 09:47
@ethanndicksonethanndickson changed the base branch fromethan/conditionally-start-daemon tographite-base/116March 24, 2025 09:49
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/116 tomainMarch 24, 2025 09:50
@ethanndicksonethanndicksonforce-pushed theethan/stubbed-fs-ui branch 4 times, most recently from227d056 to93a8e1cCompareMarch 24, 2025 13:12
@@ -48,10 +48,8 @@ struct LoginForm: View {
loginError = nil
}
}
)) {
Button("OK", role: .cancel) {}.keyboardShortcut(.defaultAction)
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I discovered this was unnecessary and removed it everywhere. AnOK button always appears on alerts, and it always gets selected by pressing enter.

@ethanndicksonethanndicksonforce-pushed theethan/stubbed-fs-ui branch 2 times, most recently from9f92961 to82cc4baCompareMarch 25, 2025 02:10
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 28, 2025•
edited
Loading

Merge activity

  • Mar 27, 10:47 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Mar 27, 10:47 PM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commitf0cf155 intomainMar 28, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/stubbed-fs-ui branchMarch 28, 2025 02:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@ThomasK33ThomasK33Awaiting requested review from ThomasK33

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add local folder picker to file sync GUI
2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp