Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: conditionally start file sync daemon#115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromethan/conditionally-start-daemon
Mar 24, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMar 20, 2025•
edited
Loading

This makes a few improvements to#98:

  • The mutagen path & data directory can be now be configured on the MutagenDaemon, to support overriding it in tests (coming soon).
  • A mutagen daemon failure now kills the process, such that can it be restarted (TBC).
  • Makes start & stop transitions mutually exclusive via a semaphore, to account for actor re-entrancy.
  • The start operation now waits for the daemon to respond to a version request before completing.
  • The daemon is always started on launch, but then immediately stopped if it doesn't manage any file sync sessions, as to not run in the background unncessarily.

@ethanndicksonethanndickson marked this pull request as ready for reviewMarch 20, 2025 02:59
if state.startVPNOnLaunch {
vpn.startWhenReady = true
}
vpn.installSystemExtension()
fileSyncDaemon = MutagenDaemon(
mutagenPath: Bundle.main.url(forResource: "mutagen-darwin-arm64", withExtension: nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't this be CPU arch-specific?

ethanndickson reacted with heart emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

True!

Copy link
Member

@ThomasK33ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, if the platform-specific binary gets fetched, this can get merged.
No need to re-review.

matifali reacted with thumbs up emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 24, 2025•
edited
Loading

Merge activity

  • Mar 24, 5:49 AM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Mar 24, 5:49 AM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit4fb7970 intomainMar 24, 2025
3 of 4 checks passed
@ethanndicksonethanndickson deleted the ethan/conditionally-start-daemon branchMarch 24, 2025 09:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ThomasK33ThomasK33ThomasK33 approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@ThomasK33
[8]ページ先頭
©2009-2025 Movatter.jp