Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: prompt for sign in when turning VPN on if signed out#114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/toggle-prompt-sign-in
Mar 19, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMar 19, 2025•
edited
Loading

Closes#106.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 19, 2025•
edited
Loading

@@ -23,7 +23,7 @@ struct VPNMenuTests {
try await ViewHosting.host(view) {
try await sut.inspection.inspect { view in
let toggle = try view.find(ViewType.Toggle.self)
#expect(toggle.isDisabled())
#expect(!toggle.isDisabled())
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The toggle is now enabled when signed out.

@ethanndicksonethanndickson marked this pull request as ready for reviewMarch 19, 2025 03:04
@ethanndicksonethanndickson self-assigned thisMar 19, 2025
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 19, 2025•
edited
Loading

Merge activity

  • Mar 19, 3:48 AM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Mar 19, 3:50 AM EDT:Graphite rebased this pull request as part of a merge.
  • Mar 19, 3:52 AM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/only-start-when-ready tographite-base/114March 19, 2025 07:49
@ethanndicksonethanndickson changed the base branch fromgraphite-base/114 tomainMarch 19, 2025 07:49
@ethanndicksonethanndicksonforce-pushed theethan/toggle-prompt-sign-in branch from830002a to982a23fCompareMarch 19, 2025 07:50
@ethanndicksonethanndickson merged commit2603ace intomainMar 19, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/toggle-prompt-sign-in branchMarch 19, 2025 07:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ThomasK33ThomasK33ThomasK33 approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turning on VPN while signed out should prompt for login
3 participants
@ethanndickson@ThomasK33@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp