- Notifications
You must be signed in to change notification settings - Fork5
chore: prompt for sign in when turning VPN on if signed out#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+19 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
ethanndickson commentedMar 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
tryawait sut.inspection.inspect{ viewin | ||
lettoggle=try view.find(ViewType.Toggle.self) | ||
#expect(toggle.isDisabled()) | ||
#expect(!toggle.isDisabled()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The toggle is now enabled when signed out.
deansheather approved these changesMar 19, 2025
ThomasK33 approved these changesMar 19, 2025
MemberAuthor
ethanndickson commentedMar 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
830002a
to982a23f
Compare2603ace
intomain 4 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ethanndickson added a commit that referenced this pull requestJul 24, 2025
I undid the work of#114 in#158, by disabling the VPN toggle when the network extension was unconfigured.When signed out, the network extension is unconfigured.This PR adds a special exception to make the VPN toggle always clickable when signed out, as it has special behaviour when signed out.It also adds a proper regression test. A slightly different regression test existed, but it didn't account for cases where the VPN state is one that would normally disable the toggle.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#106.