- Notifications
You must be signed in to change notification settings - Fork5
chore: prompt for sign in when turning VPN on if signed out#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ethanndickson commentedMar 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
tryawait sut.inspection.inspect{ viewin | ||
lettoggle=try view.find(ViewType.Toggle.self) | ||
#expect(toggle.isDisabled()) | ||
#expect(!toggle.isDisabled()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The toggle is now enabled when signed out.
ethanndickson commentedMar 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
830002a
to982a23f
Compare2603ace
intomainUh oh!
There was an error while loading.Please reload this page.
I undid the work of#114 in#158, by disabling the VPN toggle when the network extension was unconfigured.When signed out, the network extension is unconfigured.This PR adds a special exception to make the VPN toggle always clickable when signed out, as it has special behaviour when signed out.It also adds a proper regression test. A slightly different regression test existed, but it didn't account for cases where the VPN state is one that would normally disable the toggle.
Uh oh!
There was an error while loading.Please reload this page.
Closes#106.