- Notifications
You must be signed in to change notification settings - Fork3
fix: start coder connect on launch after SE is installed#113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ethanndickson commentedMar 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
| deinit { | ||
| NotificationCenter.default.removeObserver(self) | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Drive-by fix: this was on the wrong class, though that wasn't causing any issues.
| try Mock( | ||
| url: url.appendingPathComponent("/api/v2/users/me"), | ||
| statusCode: 200, | ||
| data: [.get: Client.encoder.encode(User(id: UUID(), username: "username"))] | ||
| ).register() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Drive-by fix: We need to mock this route as the token is validated before the server version.
ethanndickson commentedMar 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
111b30c intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This is a fix for#108. Previously we would start the VPN immediately on launch if the config option was true. This starting of the VPN raced with any concurrent upgrades of the network extension, causing the VPN to be started with a VPN config belonging to the older network extension, and producing a consistent error message:
Instead, we should only start the VPN once we know that the system extension and VPN configuration are installed.