Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add mutagen gRPC client#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 4 commits intomainfromethan/mutagen-grpc-client
Mar 18, 2025
Merged

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMar 13, 2025•
edited
Loading

Closescoder/internal#379

Much like incoder/coder-desktop-windows#48, this PR addsmutagen-proto.sh which finds all required files, followingimports.

Right now, we use this client to stop the daemon over gRPC.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 13, 2025•
edited
Loading

mutagen_tag="$1"

# TODO: Change this to `coder/mutagen` once we add a version tag there
repo="mutagen-io/mutagen"
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same deal as on the Windows repo, I'll make a follow-up once we have a tag.


# This script vendors the Mutagen proto files from a tag on a Mutagen GitHub repo.
# It is very similar to `Update-Proto.ps1` on `coder/coder-desktop-windows`.
# It's very unlikely that we'll use this script regularly.
Copy link
MemberAuthor

@ethanndicksonethanndicksonMar 13, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In saying that, we could not commit any part of this SDK to the repo, and just generate them as part ofmake setup? I'm not sure which I'd prefer.

The Windows repo commits the.proto files (but the C# compiler can handle them at compile time), and we already commit.pb.swift files here for the VPN protocol.

@ethanndicksonethanndickson changed the base branch fromethan/replace-dir-spaces tographite-base/111March 13, 2025 02:54
@ethanndicksonethanndicksonforce-pushed theethan/mutagen-grpc-client branch from008f582 tob7a0a77CompareMarch 13, 2025 02:54
@ethanndicksonethanndickson changed the base branch fromgraphite-base/111 tomainMarch 13, 2025 02:55
@ethanndicksonethanndicksonforce-pushed theethan/mutagen-grpc-client branch fromb7a0a77 to26c3593CompareMarch 13, 2025 02:55
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's fine that you're committing them all to the repo. Your call on what to do though

ethanndickson reacted with heart emoji
Copy link
Member

@ThomasK33ThomasK33 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Vendoring the protos is up to you.

Since one has to runmake setup anyway to get an Xcode project, it's more of a question of personal preference whether you want it to be checked in or not.

@ethanndicksonethanndicksonforce-pushed theethan/mutagen-grpc-client branch from31aeac0 to1f5dd2eCompareMarch 18, 2025 03:29
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 18, 2025•
edited
Loading

Merge activity

  • Mar 17, 11:40 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Mar 17, 11:40 PM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit0550ad1 intomainMar 18, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/mutagen-grpc-client branchMarch 18, 2025 03:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ThomasK33ThomasK33ThomasK33 approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build a mutagen API client for coder-desktop-macos

3 participants

@ethanndickson@ThomasK33@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp