Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: replace spaces with hyphens in directory names#110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 3 commits intomainfromethan/replace-dir-spaces
Mar 13, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMar 12, 2025•
edited
Loading

Builds, passes tests, and a release build works:https://github.com/coder/coder-desktop-macos/actions/runs/13804258363

The main app target is stillCoder Desktop, just not the names of any directories.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 12, 2025•
edited
Loading

@ethanndicksonethanndickson self-assigned thisMar 12, 2025
@ethanndicksonethanndickson marked this pull request as ready for reviewMarch 12, 2025 05:42
@ethanndicksonethanndickson changed the base branch fromethan/ci-mutagen-binary tographite-base/110March 12, 2025 05:44
@ethanndicksonethanndickson changed the base branch fromgraphite-base/110 tomainMarch 12, 2025 05:47
@ethanndicksonethanndickson changed the titlerefactor: replace space with hyphen in directory namesrefactor: replace spaces with hyphens in directory namesMar 12, 2025
Copy link
Member

@ThomasK33ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, great work.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 13, 2025•
edited
Loading

Merge activity

  • Mar 12, 10:54 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Mar 12, 10:54 PM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commite8e4004 intomainMar 13, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/replace-dir-spaces branchMarch 13, 2025 02:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ThomasK33ThomasK33ThomasK33 approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@ThomasK33
[8]ページ先頭
©2009-2025 Movatter.jp