Adds a stockAbout popup.
Adds aSecureSession that writes the session token to the keychain, and the server URL toUserDefaults.
Adds an initialClient for the Swiftcoderd SDK. Currently only supports theusers endpoint for validating a session token.

Screen.Recording.2024-12-11.at.5.40.42.pm.mov

The 'generate a token' hyperlink takes the user to/cli-auth.

feat: add login flow & session management

6b1e939

Copy link

MemberAuthor

ethanndickson commentedDec 11, 2024•
edited
Loading

feat: add login flow & session management #10 👈(View in Graphite)
main

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

ethanndickson requested review fromspikecurtis anddeansheather

December 11, 2024 06:47

ethanndickson marked this pull request as ready for review

December 11, 2024 06:47

deansheather approved these changes

Dec 11, 2024

View reviewed changes

Copy link

Member

deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, I like the tests

centre login form in window

7477b2f

Copy link

MemberAuthor

ethanndickson commentedDec 11, 2024•
edited
Loading

I didn't like that the form wasn't centered in the window, so it looks like this now. The macOS screenshot tool tells me the padding at the top and bottom is the same (50px).

I don't love the progress view (spinner), so I might get rid of it. I think the buttons disabling/dimming is enough feedback.

spikecurtis reviewed

Dec 11, 2024

View reviewed changes

Coder Desktop/Coder Desktop/SDK/Client.swiftShow resolvedHide resolved

Coder Desktop/Coder Desktop/SDK/Client.swift OutdatedShow resolvedHide resolved

Coder Desktop/Coder Desktop/SDK/Client.swiftShow resolvedHide resolved

Coder Desktop/Coder Desktop/SDK/Client.swift

		}

		enum ClientError: Error {
		case unexpectedStatusCode

Copy link

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	case unexpectedStatusCode
	case unexpectedStatusCode(Int)

This lets you store the status code

Coder Desktop/Coder Desktop/SDK/User.swift

		func user(_ ident: String) async throws -> User {
		let resp = await request("/api/v2/users/\(ident)", method: .get)
		guard let response = resp.response, response.statusCode == 200 else {
		throw ClientError.unexpectedStatusCode

Copy link

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fine for now, but we should be parsing the generic error responses for debugging/troubleshooting

e.g.https://github.com/coder/coder/blob/b39becba66f1c6ad9c8d73694b0d8779cf7467a2/codersdk/client.go#L495

Coder Desktop/Coder Desktop/Views/LoginForm.swiftShow resolvedHide resolved

Coder Desktop/Coder DesktopTests/AgentsTests.swift OutdatedShow resolvedHide resolved

review p1 + port xctests to swift testing

790d048

ethanndickson commented

Dec 12, 2024

View reviewed changes

Coder Desktop/Coder Desktop/Views/Agents.swift

		}
		}
		}.onReceive(inspection.notice) { self.inspection.visit(self, $0) } // ViewInspector

Copy link

MemberAuthor

ethanndicksonDec 12, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I absolutely hate that you need to modify your UI code to get the tests to work, but you do. Ifnalexn/ViewInspector#231 is ever resolved you'd be able to just wrap the view with the inspector at test-time instead.