Commitc244963

committed

chore: sign user out if token expired

1 parent6947811 commitc244963Copy full SHA for c244963

File tree

+46

-11

lines changed

+46

-11

lines changed

Lines changed: 15 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,11 +40,21 @@ class AppDelegate: NSObject, NSApplicationDelegate {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`func applicationDidFinishLaunching(_:Notification){`
`43`		`- menuBar=.init(menuBarExtra:FluidMenuBarExtra(title:"Coder Desktop", image:"MenuBarIcon"){`
`44`		`-VPNMenu<CoderVPNService>().frame(width:256)`
`45`		`-.environmentObject(self.vpn)`
`46`		`-.environmentObject(self.state)`
`47`		`-})`
	`43`	`+ menuBar=.init(menuBarExtra:FluidMenuBarExtra(`
	`44`	`+ title:"Coder Desktop",`
	`45`	`+ image:"MenuBarIcon",`
	`46`	`+ onAppear:{`
	`47`	`+ // If the VPN is enabled, it's likely the token isn't expired`
	`48`	`+guard case.disabled=self.vpn.state,self.state.hasSessionelse{return}`
	`49`	`+Task{@MainActorin`
	`50`	`+awaitself.state.handleTokenExpiry()`
	`51`	`+}`
	`52`	`+}, content:{`
	`53`	`+VPNMenu<CoderVPNService>().frame(width:256)`
	`54`	`+.environmentObject(self.vpn)`
	`55`	`+.environmentObject(self.state)`
	`56`	`+}`
	`57`	`+))`
`48`	`58`	`// Subscribe to system VPN updates`
`49`	`59`	`NotificationCenter.default.addObserver(`
`50`	`60`	`self,`

Lines changed: 23 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,10 +2,12 @@ import CoderSDK`
`2`	`2`	`import Foundation`
`3`	`3`	`import KeychainAccess`
`4`	`4`	`import NetworkExtension`
	`5`	`+import os`
`5`	`6`	`import SwiftUI`
`6`	`7`
`7`	`8`	`@MainActor`
`8`	`9`	`classAppState:ObservableObject{`
	`10`	`+privateletlogger=Logger(subsystem:Bundle.main.bundleIdentifier!, category:"AppState")`
`9`	`11`	`letappId=Bundle.main.bundleIdentifier!`
`10`	`12`
`11`	`13`	`// Stored in UserDefaults`
`@@ -95,6 +97,9 @@ class AppState: ObservableObject {`
`95`	`97`	`)`
`96`	`98`	`if hasSession{`
`97`	`99`	`_sessionToken=Published(initialValue:keychainGet(for:Keys.sessionToken))`
	`100`	`+if sessionToken==nil \|\| sessionToken!.isEmpty==true{`
	`101`	`+clearSession()`
	`102`	`+}`
`98`	`103`	`}`
`99`	`104`	`}`
`100`	`105`
`@@ -105,6 +110,24 @@ class AppState: ObservableObject {`
`105`	`110`	`reconfigure()`
`106`	`111`	`}`
`107`	`112`
	`113`	`+publicfunc handleTokenExpiry()async{`
	`114`	`+if hasSession{`
	`115`	`+letclient=Client(url: baseAccessURL!, token: sessionToken!)`
	`116`	`+do{`
	`117`	`+ _=tryawait client.user("me")`
	`118`	`+}catchletClientError.api(apiErr){`
	`119`	`+ // Expired token`
	`120`	`+if apiErr.statusCode==401{`
	`121`	`+clearSession()`
	`122`	`+}`
	`123`	`+}catch{`
	`124`	`+ // Some other failure, we'll show an error if they try and do something`
	`125`	`+ logger.error("failed to check token validity:\(error)")`
	`126`	`+return`
	`127`	`+}`
	`128`	`+}`
	`129`	`+}`
	`130`	`+`
`108`	`131`	`publicfunc clearSession(){`
`109`	`132`	`hasSession=false`
`110`	`133`	`sessionToken=nil`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,10 +104,10 @@ public struct Client {`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`publicstructAPIError:Decodable,Sendable{`
`107`		`-letresponse:Response`
`108`		`-letstatusCode:Int`
`109`		`-letmethod:String`
`110`		`-leturl:URL`
	`107`	`+publicletresponse:Response`
	`108`	`+publicletstatusCode:Int`
	`109`	`+publicletmethod:String`
	`110`	`+publicleturl:URL`
`111`	`111`
`112`	`112`	`vardescription:String{`
`113`	`113`	`varcomponents=["\(method)\(url.absoluteString)\nUnexpected status code\(statusCode):\n\(response.message)"]`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -92,10 +92,12 @@ packages:`
`92`	`92`	`url:https://github.com/SimplyDanny/SwiftLintPlugins`
`93`	`93`	`from:0.57.1`
`94`	`94`	`FluidMenuBarExtra:`
`95`		`-# Forked so we can dynamically update the menu bar icon.`
	`95`	`+# Forked to:`
	`96`	`+# - Dynamically update the menu bar icon`
	`97`	`+# - Set onAppear/disappear handlers.`
`96`	`98`	`# The upstream repo has a purposefully limited API`
`97`	`99`	`url:https://github.com/coder/fluid-menu-bar-extra`
`98`		`-revision:020be37`
	`100`	`+revision:96a861a`
`99`	`101`	`KeychainAccess:`
`100`	`102`	`url:https://github.com/kishikawakatsumi/KeychainAccess`
`101`	`103`	`branch:e0c7eebc5a4465a3c4680764f26b7a61f567cdaf`

Comments

(0)