Commit3a520d5

authored

fix: canvas preview panic in Xcode resolved (#82)

The preview was panicking because the app state had an optional base URL, which is getting unwrapped elsewhere. This creates an app state and then 'logs in' to set the base URL, reenabling the preview.Change-Id: I8d6a19063a13f772dc409bc5e523e1af9c109beeSigned-off-by: Thomas Kosiewski <tk@coder.com>

1 parent5b4b174 commit3a520d5Copy full SHA for 3a520d5

File tree

3 files changed

-3

lines changed

Coder Desktop/Coder Desktop
- State.swift
- Views
  - LoginForm.swift
  - VPNMenu.swift

3 files changed

-3

lines changed

`‎Coder Desktop/Coder Desktop/State.swift`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ class AppState: ObservableObject {`
`25`	`25`	`// Stored in Keychain`
`26`	`26`	`@Publishedprivate(set)varsessionToken:String?{`
`27`	`27`	`didSet{`
	`28`	`+guard persistentelse{return}`
`28`	`29`	`keychainSet(sessionToken, for:Keys.sessionToken)`
`29`	`30`	`}`
`30`	`31`	`}`

`‎Coder Desktop/Coder Desktop/Views/LoginForm.swift`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -221,6 +221,6 @@ enum LoginField: Hashable {`
`221`	`221`	`#if DEBUG`
`222`	`222`	`#Preview{`
`223`	`223`	`LoginForm()`
`224`		`-.environmentObject(AppState())`
	`224`	`+.environmentObject(AppState(persistent:false))`
`225`	`225`	`}`
`226`	`226`	`#endif`

`‎Coder Desktop/Coder Desktop/Views/VPNMenu.swift`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,8 +104,12 @@ func openSystemExtensionSettings() {`
`104`	`104`
`105`	`105`	`#if DEBUG`
`106`	`106`	`#Preview{`
`107`		`-VPNMenu<PreviewVPN>().frame(width:256)`
	`107`	`+letappState=AppState(persistent:false)`
	`108`	`+ appState.login(baseAccessURL:URL(string:"http://127.0.0.1:8080")!, sessionToken:"")`
	`109`	`+ // appState.clearSession()`
	`110`	`+`
	`111`	`+returnVPNMenu<PreviewVPN>().frame(width:256)`
`108`	`112`	`.environmentObject(PreviewVPN())`
`109`		`-.environmentObject(AppState(persistent:false))`
	`113`	`+.environmentObject(appState)`
`110`	`114`	`}`
`111`	`115`	`#endif`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3a520d5

File tree

3 files changed

3 files changed

`‎Coder Desktop/Coder Desktop/State.swift`

`‎Coder Desktop/Coder Desktop/Views/LoginForm.swift`

`‎Coder Desktop/Coder Desktop/Views/VPNMenu.swift`

0 commit comments