Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: only allow promoting successful template versions#9998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 11 commits intomainfromonly-promote-successful-builds
Oct 5, 2023

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedOct 2, 2023•
edited
Loading

Closes#9904

  • Add a check on the backend to prevent promoting an invalid version which has a failed/canceled/unfinished build
  • Disable the "promote" button on the frontend to match
  • Add "failed", "canceling", "building", and "pending" badges in the UI for versions with corresponding states
  • Avoid showing the "newest" badge on versions that aren't valid
  • Hide "canceled" versions from the UI entirely

sreya and matifali reacted with rocket emoji
@aslilac

This comment was marked as resolved.

@aslilacaslilacforce-pushed theonly-promote-successful-builds branch from70e9cd6 to6dc8fc3CompareOctober 2, 2023 23:23
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

FE code looks good but since most of the changes are related to Go, I would also request a review from someone with more expertise on that

@aslilacaslilac requested a review frommatifaliOctober 3, 2023 22:58
@aslilacaslilac merged commitf001a57 intomainOct 5, 2023
@aslilacaslilac deleted the only-promote-successful-builds branchOctober 5, 2023 16:49
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma left review comments

@spikecurtisspikecurtisspikecurtis approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

@matifalimatifaliAwaiting requested review from matifali

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

do not allow promotion of a failed template version
3 participants
@aslilac@BrunoQuaresma@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp