Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add the preferences/account page#999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 35 commits intomainfrombq/755/account-page
Apr 15, 2022
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedApr 13, 2022•
edited
Loading

Hey folks, I added some components and “helper” functions on this PR that could be useful for the team:

  • renderWithAuth - test helper to render authenticated pages
  • <FormStack> - to make the spacing between the fields consistent
  • getFormErrorsFromApiError - map API errors to formik errors

Closes#755

@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 13, 2022
@BrunoQuaresmaBrunoQuaresma requested review frompresleyp anda team ascode ownersApril 13, 2022 21:56
@codecov
Copy link

codecovbot commentedApr 13, 2022•
edited
Loading

Codecov Report

Merging#999 (59bac76) intomain (1c55572) willincrease coverage by9.99%.
The diff coverage is86.25%.

@@            Coverage Diff             @@##             main     #999      +/-   ##==========================================+ Coverage   57.35%   67.35%   +9.99%==========================================  Files         256      259       +3       Lines       14987    15059      +72       Branches      136      151      +15     ==========================================+ Hits         8596    10143    +1547+ Misses       5473     3896    -1577- Partials      918     1020     +102
FlagCoverage Δ
unittest-go-macos-latest53.63% <ø> (-0.13%)⬇️
unittest-go-postgres-66.62% <ø> (?)
unittest-go-ubuntu-latest56.01% <ø> (-0.16%)⬇️
unittest-go-windows-202252.98% <ø> (-0.09%)⬇️
unittest-js68.20% <86.25%> (+5.22%)⬆️
Impacted FilesCoverage Δ
site/src/components/Page/RequireAuth.tsx87.50% <0.00%> (+87.50%)⬆️
site/src/test_helpers/entities.ts100.00% <ø> (ø)
site/src/api/index.ts62.79% <50.00%> (-2.21%)⬇️
site/src/xServices/auth/authXService.ts80.00% <77.77%> (-1.82%)⬇️
site/src/test_helpers/index.tsx94.44% <83.33%> (-5.56%)⬇️
site/src/api/errors.ts85.71% <85.71%> (ø)
site/src/components/Stack/Stack.tsx85.71% <85.71%> (ø)
site/src/pages/preferences/account.tsx89.47% <88.23%> (+89.47%)⬆️
site/src/components/Form/index.ts100.00% <100.00%> (ø)
site/src/components/Preferences/AccountForm.tsx100.00% <100.00%> (ø)
... and24 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update1c55572...59bac76. Read thecomment docs.

BrunoQuaresmaand others added2 commitsApril 14, 2022 19:01
BrunoQuaresmaand others added2 commitsApril 14, 2022 16:29
Co-authored-by: G r e y <grey@coder.com>
Co-authored-by: G r e y <grey@coder.com>
expect(
mapApiErrorToFieldErrors({
message: "Invalid entry",
errors: [{ detail: "Username is already in use", field: "username" }],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I love having these tests because it helps me see what the data structure looks like :)

BrunoQuaresma and greyscaled reacted with heart emoji
Copy link
Contributor

@presleyppresleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work!

BrunoQuaresma reacted with heart emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@presleyppresleyppresleyp approved these changes

@greyscaledgreyscaledgreyscaled approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

User Preferences Account page
4 participants
@BrunoQuaresma@presleyp@greyscaled@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp