NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: Add alias`coder agent`#986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

f0ssel merged 4 commits intomainfromf0ssel/agent-alias

Apr 13, 2022

Merged

chore: Add alias`coder agent`#986

f0ssel merged 4 commits intomainfromf0ssel/agent-alias

Apr 13, 2022

Conversation

Copy link

Contributor

f0ssel commentedApr 12, 2022

No description provided.

f0ssel requested a review fromkylecarbs

April 12, 2022 22:10

chore: Add aliascoder agent

7dd7e08

f0ssel force-pushed thef0ssel/agent-alias branch from595cb66 to7dd7e08Compare

April 12, 2022 22:11

f0ssel changed the title~~Add aliascoder agent~~chore: Add aliascoder agent

Apr 12, 2022

Copy link

codecovbot commentedApr 12, 2022•
edited
Loading

Codecov Report

Merging#986 (e1c5afb) intomain (ce49966) willdecrease coverage by0.10%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main     #986      +/-   ##==========================================- Coverage   66.53%   66.42%   -0.11%==========================================  Files         240      237       -3       Lines       14588    14404     -184       Branches      115      115              ==========================================- Hits         9706     9568     -138+ Misses       3892     3864      -28+ Partials      990      972      -18

Flag	Coverage Δ
unittest-go-macos-latest	`53.57% <100.00%> (+0.09%)`	⬆️
unittest-go-postgres-	`66.41% <100.00%> (+0.12%)`	⬆️
unittest-go-ubuntu-latest	`55.97% <100.00%> (-0.18%)`	⬇️
unittest-go-windows-2022	`?`
unittest-js	`61.56% <ø> (ø)`

Impacted Files	Coverage Δ
cli/agent.go	`76.08% <ø> (ø)`
cli/workspaces.go	`53.12% <ø> (-1.43%)`	⬇️
provisionersdk/agent.go	`100.00% <ø> (ø)`
cli/root.go	`77.27% <100.00%> (+0.20%)`	⬆️
cli/configssh.go	`61.41% <0.00%> (-7.09%)`	⬇️
pty/ptytest/ptytest.go	`89.65% <0.00%> (-5.18%)`	⬇️
cli/templateinit.go	`58.62% <0.00%> (-3.45%)`	⬇️
peerbroker/listen.go	`84.16% <0.00%> (-3.34%)`	⬇️
peer/conn.go	`77.41% <0.00%> (-1.53%)`	⬇️
peer/channel.go	`84.97% <0.00%> (-0.58%)`	⬇️
... and9 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatece49966...e1c5afb. Read thecomment docs.

kylecarbs reviewed

Apr 12, 2022

View reviewed changes

Copy link

Member

kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we move the command instead? I think it's weird to alias a hidden command anyways.

move command

8ad6bb1

Copy link

ContributorAuthor

f0ssel commentedApr 13, 2022•
edited
Loading

@kylecarbs I couldn't find any more references to callingcoder workspace agent in the repo, but I assume there's one somewhere for the terraform. Is there a place I'm probably missing?