- Notifications
You must be signed in to change notification settings - Fork928
feat(scaletest): add grafana annotations and slack reporting#9852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| --count "${SCALETEST_PARAM_NUM_WORKSPACES}" \ | ||
| --template "${SCALETEST_PARAM_TEMPLATE}" \ | ||
| --concurrency "${SCALETEST_PARAM_CREATE_CONCURRENCY}" \ | ||
| --job-timeout2h \ | ||
| --no-cleanup \ | ||
| --output json:"${SCALETEST_RESULTS_DIR}/create-workspaces.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: Since you're prefixing everything else withSCALETEST_PARAM_, perhaps also this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was thinking about them separately, one is params that a user can change (via template) and the other is plain variables used by the suite. Since allSCALETEST_PARAM_ prefixed vars are attached to reports in sorted order, this also gives us more control what to report/where.
| # shellcheck disable=SC2153 source=scaletest/templates/scaletest-runner/scripts/lib.sh | ||
| . "${SCRIPTS_DIR}/lib.sh" | ||
| # NOTE(mafredri): API returns HTML if we accidentally use `...//api` vs `.../api`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👀 that sounds like a bug? (Edit: in coderd, I mean)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We could consider it one. Funnily enough, Grafana has the same issue (you get page not found). 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not a blocker for this though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but I will defer the final approval to Cian.
| order = 25 | ||
| name = "Dashboard Traffic Duration" | ||
| type = "number" | ||
| description = "The duration of the dashboard traffic load scenario in minutes." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: alternatively, we could use a select box with predefined periods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's a good idea, perhaps once we have a better idea of what those predefined periods should be. 👍🏻
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#9575
Fixes#9576