Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): Read users into basic UsersTable#981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
presleyp merged 26 commits intomainfromusers-table/presleyp/592
Apr 14, 2022

Conversation

presleyp
Copy link
Contributor

@presleyppresleyp commentedApr 12, 2022•
edited
Loading

AC:

  • /users should contain a header and a table
  • Header should list the total number of users
  • Table should have a User column containing the user avatar, username, and email address

The other columns and pagination will be done separately.

@presleyppresleyp requested a review froma team as acode ownerApril 12, 2022 17:51
@codecov
Copy link

codecovbot commentedApr 12, 2022•
edited
Loading

Codecov Report

Merging#981 (1cbc885) intomain (42e9956) willincrease coverage by0.10%.
The diff coverage is84.61%.

@@            Coverage Diff             @@##             main     #981      +/-   ##==========================================+ Coverage   66.62%   66.72%   +0.10%==========================================  Files         249      255       +6       Lines       14686    14915     +229       Branches      135      136       +1     ==========================================+ Hits         9784     9952     +168- Misses       3923     3964      +41- Partials      979      999      +20
FlagCoverage Δ
unittest-go-macos-latest53.81% <ø> (-0.11%)⬇️
unittest-go-postgres-66.44% <ø> (-0.15%)⬇️
unittest-go-ubuntu-latest56.41% <ø> (-0.09%)⬇️
unittest-go-windows-202253.31% <ø> (?)
unittest-js62.85% <84.61%> (+1.23%)⬆️
Impacted FilesCoverage Δ
site/src/AppRouter.tsx0.00% <0.00%> (ø)
site/src/test_helpers/handlers.ts22.58% <0.00%> (-1.56%)⬇️
site/src/components/ErrorSummary/index.tsx66.66% <50.00%> (+6.66%)⬆️
site/src/pages/UsersPage/UsersPage.tsx83.33% <83.33%> (ø)
site/src/xServices/users/usersXService.ts85.71% <85.71%> (ø)
site/src/api/index.ts65.00% <100.00%> (+2.83%)⬆️
site/src/components/UsersTable/UsersTable.tsx100.00% <100.00%> (ø)
site/src/pages/UsersPage/UsersPageView.tsx100.00% <100.00%> (ø)
site/src/test_helpers/entities.ts100.00% <100.00%> (ø)
site/src/xServices/StateContext.tsx100.00% <100.00%> (ø)
... and17 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update42e9956...1cbc885. Read thecomment docs.

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is great!

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approving with the suggestion and merge 🎉. I know it's listed as a merge conflict, but I ran it locally and it was a case of "yes I want both of these changes":

exportinterfacePager{total:number}exportinterfacePagedUsers{page:UserResponse[]pager:Pager}exportinterfaceWorkspaceAutostartRequest{schedule:string}exportinterfaceWorkspaceAutostopRequest{schedule:string}

I'm not sure why this is registering as a conflict, but I digress.

Awesome stuff!!

@presleyppresleyp merged commit82275a8 intomainApr 14, 2022
@presleyppresleyp deleted the users-table/presleyp/592 branchApril 14, 2022 17:57
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

3 participants
@presleyp@greyscaled@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp