NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: Rename`coder` to`sshd` on Windows for VS Code Remote support#974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kylecarbs merged 1 commit intomainfromwindowcode

Apr 12, 2022

Merged

fix: Rename`coder` to`sshd` on Windows for VS Code Remote support#974

kylecarbs merged 1 commit intomainfromwindowcode

Apr 12, 2022

Conversation

Copy link

Member

kylecarbs commentedApr 12, 2022

On Windows, VS Code Remote requires a parent process of the
executing shell to be named sshd, otherwise it fails. See:
microsoft/vscode-remote-release#5699

fix: Renamecoder tosshd on Windows for VS Code Remote support

6a32af4

On Windows, VS Code Remote requires a parent process of theexecuting shell to be named sshd, otherwise it fails. See:microsoft/vscode-remote-release#5699

kylecarbs requested a review fromcode-asher

April 12, 2022 02:07

kylecarbs self-assigned this

Apr 12, 2022

Copy link

codecovbot commentedApr 12, 2022•
edited
Loading

Codecov Report

Merging#974 (6a32af4) intomain (e8b1a57) willincrease coverage by0.06%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main     #974      +/-   ##==========================================+ Coverage   66.70%   66.76%   +0.06%==========================================  Files         241      241                Lines       14577    14577                Branches      115      115              ==========================================+ Hits         9724     9733       +9+ Misses       3867     3865       -2+ Partials      986      979       -7

Flag	Coverage Δ
unittest-go-macos-latest	`53.61% <ø> (-0.17%)`	⬇️
unittest-go-postgres-	`66.42% <ø> (+0.11%)`	⬆️
unittest-go-ubuntu-latest	`56.26% <ø> (+0.03%)`	⬆️
unittest-go-windows-2022	`53.03% <ø> (+0.04%)`	⬆️
unittest-js	`61.56% <ø> (ø)`

Impacted Files	Coverage Δ
provisionersdk/agent.go	`100.00% <ø> (ø)`
pty/start_other.go	`64.70% <0.00%> (-23.53%)`	⬇️
peerbroker/dial.go	`77.04% <0.00%> (-6.56%)`	⬇️
peer/channel.go	`83.23% <0.00%> (-1.74%)`	⬇️
peer/conn.go	`80.96% <0.00%> (-0.51%)`	⬇️
coderd/provisionerdaemons.go	`63.00% <0.00%> (-0.51%)`	⬇️
coderd/database/queries.sql.go	`83.67% <0.00%> (+0.21%)`	⬆️
provisioner/terraform/provision.go	`68.54% <0.00%> (+0.43%)`	⬆️
provisionerd/provisionerd.go	`81.17% <0.00%> (+1.17%)`	⬆️
coderd/workspaceagents.go	`61.77% <0.00%> (+1.77%)`	⬆️
... and2 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee8b1a57...6a32af4. Read thecomment docs.