Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: prevent workspace search bar text from getting garbled#9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Parkreiner merged 11 commits intomainfromfilter-fix
Sep 15, 2023

Conversation

Parkreiner
Copy link
Member

@ParkreinerParkreiner commentedSep 15, 2023
edited
Loading

Closes#9547
Addresses main issue where the text in the workspaces search bar would periodically get garbled, especially if you kept typing very fast.

Changes made

  • Replaceddebounce-it usage for the page with a home-spunuseDebouncedFunction
    • The library's debounce utility assumes it's called in regular JavaScript, so it kept creating a brand new stateful function on every single render. That was splitting up all the debounced calls, instead of having them go to one centralized place
    • There are still other parts of the codebase that need to have this swap made; will open a new issue shortly about getting those areas updated (changes were out of scope for this PR)
    • Hook has tests in place, too, just to give us more confidence when we use it in the future.
  • Reorganized some of the code and also added a few extra checks to minimize risks of accidental state desyncs between the search bar state and the global query state that it's based off of

Other notes

  • Accidentally got confused when I was learning the codebase (lowercasefilter.tsx vs uppercaseFilter.tsx), and refactored a file that didn't really need changes. Functionality is the same; it was a pure refactor.
    • Will be more dutiful about making sure PRs don't touch any unnecessary files in the future

@ParkreinerParkreiner requested review froma team andBrunoQuaresma and removed request fora teamSeptember 15, 2023 18:11
@github-actions
Copy link

github-actionsbot commentedSep 15, 2023
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ParkreinerParkreiner added bug good first issueEasily solved issues suitable for starters and community contributors s3Bugs that confuse, annoy, or are purely cosmetic labelsSep 15, 2023
@Parkreiner
Copy link
MemberAuthor

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull requestSep 15, 2023
@ParkreinerParkreiner removed s3Bugs that confuse, annoy, or are purely cosmetic bug good first issueEasily solved issues suitable for starters and community contributors labelsSep 15, 2023
@ParkreinerParkreiner changed the titlefix: Prevent workspace search bar text from getting garbled (#9547)fix: Prevent workspace search bar text from getting garbledSep 15, 2023
@ParkreinerParkreiner changed the titlefix: Prevent workspace search bar text from getting garbledfix: prevent workspace search bar text from getting garbledSep 15, 2023
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Really good one, just one minor comment.

@ParkreinerParkreiner merged commitfcc8b9e intomainSep 15, 2023
@ParkreinerParkreiner deleted the filter-fix branchSeptember 15, 2023 19:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@ParkreinerParkreiner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filter input flickers when typing fast

2 participants

@Parkreiner@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp