Sep 13, 2023 · Sep 13, 2023 · Sep 13, 2023 · Sep 13, 2023 · Sep 13, 2023 · Sep 13, 2023
diff --git a/site/e2e/playwright.config.ts b/site/e2e/playwright.config.ts
  use: {
    baseURL: `http://localhost:${port}`,
    video: "retain-on-failure",
    launchOptions: {
      args: ["--disable-webgl"],
    },
  },
  webServer: {
    url: `http://localhost:${port}/api/v2/deployment/config`,
diff --git a/site/e2e/tests/webTerminal.spec.ts b/site/e2e/tests/webTerminal.spec.ts
  const terminal = await pagePromise;
  await terminal.waitForLoadState("domcontentloaded");

  const xtermRows = await terminal.waitForSelector("div.xterm-rows", {
    state: "visible",
  });

  // Ensure that we can type in it
  await terminal.keyboard.type("echohello");
  await terminal.keyboard.type("echohe${justabreak}llo");
  await terminal.keyboard.press("Enter");

  const locator = terminal.locator("text=hello");
  // Check if "echo" command was executed
  await xtermRows.waitForSelector('div:text-matches("hello")', {
    state: "visible",
  });

  for (let i = 0; i < 10; i++) {
    const items = await locator.all();
    // Make sure the text came back
    if (items.length === 2) {
      break;
    }
    await new Promise((r) => setTimeout(r, 250));
  }
  await stopAgent(agent);
 });
Original file line number	Diff line number	Diff line change
Expand Up		@@ -34,6 +34,9 @@ export default defineConfig({
		use: {
		baseURL: `http://localhost:${port}`,
		video: "retain-on-failure",
		launchOptions: {
		args: ["--disable-webgl"],
		},
		},
		webServer: {
		url: `http://localhost:${port}/api/v2/deployment/config`,
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -41,19 +41,18 @@ test("web terminal", async ({ context, page }) => {
		const terminal = await pagePromise;
		await terminal.waitForLoadState("domcontentloaded");

		const xtermRows = await terminal.waitForSelector("div.xterm-rows", {
		state: "visible",
		});

		// Ensure that we can type in it
		await terminal.keyboard.type("echohello");
		await terminal.keyboard.type("echohe${justabreak}llo");
		await terminal.keyboard.press("Enter");

		const locator = terminal.locator("text=hello");
		// Check if "echo" command was executed
		await xtermRows.waitForSelector('div:text-matches("hello")', {
		state: "visible",
		});

		for (let i = 0; i < 10; i++) {
Copy link MemberAuthor mtojekSep 13, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. for reviewers: once this loop is over, and no items have been located, nothing happens even though the test should fail
		const items = await locator.all();
		// Make sure the text came back
		if (items.length === 2) {
		break;
		}
		await new Promise((r) => setTimeout(r, 250));
		}
		await stopAgent(agent);
		});