Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add template_id and template_name to workspace data source#9655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sreya merged 2 commits intomainfromjon/templateid
Sep 13, 2023

Conversation

sreya
Copy link
Collaborator

@sreyasreya commentedSep 13, 2023•
edited
Loading

This PR adds the plumbing necessary to inject the template ID and name into the workspace data source.

fixes#9149

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In terms of feature completeness, it is 👍

I don't see the need to exposetemplate_id if we havetemplate_name exposed. Wouldn't it be more convenient to exposetemplate_version?

@sreya
Copy link
CollaboratorAuthor

@mtojek I'm guessingid is useful because it is immutable whereas you can update the name of a template. I could seetemplate_version being useful but I'd like to wait for a use-case to surface before implementing it.

@sreyasreya merged commit3dc1e22 intomainSep 13, 2023
@sreyasreya deleted the jon/templateid branchSeptember 13, 2023 16:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@sreyasreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose template name and ID via a Terraform data source
3 participants
@sreya@kylecarbs@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp