NotificationsYou must be signed in to change notification settings
Fork929
Star10.1k

feat: Add support for VS Code and JetBrains Gateway via SSH#956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kylecarbs merged 18 commits intomainfromides

Apr 12, 2022

Merged

feat: Add support for VS Code and JetBrains Gateway via SSH#956

kylecarbs merged 18 commits intomainfromides

Apr 12, 2022

Conversation

Copy link

Member

kylecarbs commentedApr 11, 2022

This fixes various bugs that made this not work:

Incorrect max message size inpeer
Incorrect reader buffer size inpeer
Lack of SFTP support inagent
Lack of direct-tcpip support inagent
Misuse of command from session. It should always use the shell
Blocking on SSH session, only allowing one at a time

Fixes#833 too.

kylecarbs added14 commits

April 8, 2022 14:12

Improve CLI documentation

85745ab

feat: Allow workspace resources to attach multiple agents

e8258ea

This enables a "kubernetes_pod" to attach multiple agents thatcould be for multiple services. Each agent is required to havea unique name, so SSH syntax is:`coder ssh <workspace>.<agent>`A resource can have zero agents too, they aren't required.

Merge branch 'updatetfprovider' into clihelp

6abc4a4

Add tree view

b0cb66d

Improve table UI

6ed0bc0

feat: Allow workspace resources to attach multiple agents

3ad0766

This enables a "kubernetes_pod" to attach multiple agents thatcould be for multiple services. Each agent is required to havea unique name, so SSH syntax is:`coder ssh <workspace>.<agent>`A resource can have zero agents too, they aren't required.

Merge branch 'updatetfprovider' into clihelp

9cbadef

Renametunnel toskip-tunnel

4496f36

This command was `true` by default, which causesa confusing user experience.

Add disclaimer about editing templates

65c19bd

Add help to template create

c50d170

Improve workspace create flow

326f2d5

Add end-to-end test for config-ssh

008ba69

Improve testing of config-ssh

71e4544

Fix workspace list

8fecb67

kylecarbs requested review fromjohnstcn andf0ssel

April 11, 2022 16:49

kylecarbs self-assigned this

Apr 11, 2022

kylecarbs force-pushed theides branch from5f8736c to1a10358Compare

April 11, 2022 16:55

Copy link

codecovbot commentedApr 11, 2022•
edited
Loading

Codecov Report

Merging#956 (81f3849) intomain (fb9dc4f) willincrease coverage by0.07%.
The diff coverage is73.33%.

@@            Coverage Diff             @@##             main     #956      +/-   ##==========================================+ Coverage   66.55%   66.63%   +0.07%==========================================  Files         241      241                Lines       14582    14577       -5       Branches      115      115              ==========================================+ Hits         9705     9713       +8+ Misses       3887     3881       -6+ Partials      990      983       -7

Flag	Coverage Δ
unittest-go-macos-latest	`53.52% <73.33%> (-0.18%)`	⬇️
unittest-go-postgres-	`66.39% <73.33%> (-0.03%)`	⬇️
unittest-go-ubuntu-latest	`56.29% <73.33%> (-0.02%)`	⬇️
unittest-go-windows-2022	`53.03% <73.33%> (+0.04%)`	⬆️
unittest-js	`61.56% <ø> (ø)`

Impacted Files	Coverage Δ
agent/agent.go	`64.59% <70.37%> (-3.47%)`	⬇️
peer/channel.go	`83.23% <100.00%> (+0.19%)`	⬆️
peerbroker/proxy.go	`57.55% <0.00%> (-4.07%)`	⬇️
coderd/workspaceagents.go	`60.00% <0.00%> (-1.78%)`	⬇️
provisioner/terraform/provision.go	`68.11% <0.00%> (-0.44%)`	⬇️
provisionerd/provisionerd.go	`80.29% <0.00%> (+0.29%)`	⬆️
coderd/provisionerdaemons.go	`63.51% <0.00%> (+0.50%)`	⬆️
peer/conn.go	`80.45% <0.00%> (+2.79%)`	⬆️
peerbroker/listen.go	`87.50% <0.00%> (+3.33%)`	⬆️
... and2 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatefb9dc4f...81f3849. Read thecomment docs.

kylecarbs force-pushed theides branch from1a10358 to9435f6cCompare

April 11, 2022 17:33

feat: Add support for VS Code and JetBrains Gateway via SSH

c625594

This fixes various bugs that made this not work:- Incorrect max message size in `peer`- Incorrect reader buffer size in `peer`- Lack of SFTP support in `agent`- Lack of direct-tcpip support in `agent`- Misuse of command from session. It should always use the shell- Blocking on SSH session, only allowing one at a timeFixes#833 too.