Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coderd): connect dbcrypt package implementation#9523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 38 commits intomainfromcj/dbcrypt_redux_2
Sep 7, 2023

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedSep 4, 2023•
edited
Loading

Reimplementation of#9433 following PR feedback.

This builds upon#9522. It is recommended to read that first.

  • Adds commandsserver dbcrypt {rotate,decrypt,delete} to re-encrypt, decrypt, or delete encrypted data, respectively.
  • Plumbs through dbcrypt in enterprise/coderd (including unit tests).
  • Adds documentation in admin/encryption.md.

Note: This essentially enables dbcryptby default, but the feature is soft-enforced on supplying external token encryption keys. Without specifying any keys, encryption/decryption is a no-op.

johnstcnand others added2 commitsSeptember 4, 2023 20:43
- Adds package enterprise/dbcrypt to implement database encryption/decryption- Adds table dbcrypt_keys and associated queries- Adds columns oauth_access_token_key_id and oauth_refresh_token_key_id  to tables git_auth_links and user_linksNOTE: This is part 1 of a 2-part PR. This PR focusesmainly on the dbcrypt and database packages. A separatePR will add the required plumbing to integrate this intoenterprise/coderd properly.Co-authored-by: Kyle Carberry <kyle@coder.com>
This builds upon a previous PR. It is recommended to read that first.- Adds a command dbcrypt-rotate to re-enncrypt encrypted data- Plumbs through dbcrypt in enterprise/coderd (including unit tests)- Enables database encryption in develop.sh by default- Adds documentation in admin/encryption.md
@johnstcnjohnstcn self-assigned thisSep 4, 2023
@johnstcnjohnstcn marked this pull request as ready for reviewSeptember 5, 2023 09:11
@johnstcnjohnstcn changed the titlefeat(coderd): plumb through dbcrypt packagefeat(coderd): connect dbcrypt package implementationSep 5, 2023
Base automatically changed fromcj/dbcrypt_redux_1 tomainSeptember 6, 2023 11:06
johnstcnand others added16 commitsSeptember 6, 2023 16:04
@johnstcn
Copy link
MemberAuthor

Thanks@deansheather@mtojek@spikecurtis for your excellent review feedback and comments!

@johnstcnjohnstcn merged commit7d7c84b intomainSep 7, 2023
@johnstcnjohnstcn deleted the cj/dbcrypt_redux_2 branchSeptember 7, 2023 14:49
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@mtojekmtojekAwaiting requested review from mtojek

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@johnstcn@spikecurtis@deansheather@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp